Thanks for the contribution:). Reviewed-By: Wu Jiaxin <[email protected]>
Best Regards! Jiaxin > -----Original Message----- > From: Zhang, Lubo > Sent: Thursday, July 21, 2016 4:50 PM > To: Michael Chang <[email protected]>; Wu, Jiaxin <[email protected]> > Cc: [email protected] > Subject: RE: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data > > If no other comments, I will ask jiaxin to help you check in your patch. > > Reviewed-by: Zhang Lubo <[email protected]> > > Thanks > Lubo > > -----Original Message----- > > From: Michael Chang [mailto:[email protected]] > > Sent: Thursday, July 21, 2016 4:20 PM > > To: Zhang, Lubo <[email protected]> > > Cc: [email protected] > > Subject: Re: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data > > > > On Thu, Jul 21, 2016 at 02:40:35AM +0000, Zhang, Lubo wrote: > > > Yes, the wrong length definition of the ClassIdentifier lead to a > > > wrong > > location CopyMem for system architecture when we build the vendor > > class option. Thanks for your correction. > > > Do you have access to check in the code? > > > > No. I don't. I also do not know other alternatives like sending pull > > request to the git repo instead of sending patch to the list. I am > > absoutely fine to follow any instrctions here to get the fix > > committed, just tell me (could via the private mails or so) for any other > procedures I should take. > > > > > > > > Best Regards > > > Lubo > > > > > > -----Original Message----- > > > From: edk2-devel [mailto:[email protected]] On Behalf > > > Of Michael Chang > > > Sent: Thursday, July 21, 2016 9:59 AM > > > To: [email protected] > > > Subject: [edk2] [PATCH] Fix IPv6 HTTPClient vendor class data > > > > > > The size of the ClassIdentifier is apparently wrong in the > > > structure. In my > > testing it caused the vendor class data to be displayed as bogus > > "HTTPClient:Arch00016x:UNDI00300". After correcting the size the > > vendor class data is "HTTPClient:Arch00016:UNDI003000" which looks good > to me. > > > > Gary reminded me missed out the necessary tags contributing the patch > > to the project so here it is. :) > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Michael Chang <[email protected]> > > > > > > > > --- > > > NetworkPkg/HttpBootDxe/HttpBootDhcp6.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h > > > b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h > > > index f9eec9d..14d6db0 100644 > > > --- a/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h > > > +++ b/NetworkPkg/HttpBootDxe/HttpBootDhcp6.h > > > @@ -50,7 +50,7 @@ typedef struct { > > > } HTTP_BOOT_DHCP6_OPTION_ARCH; > > > > > > typedef struct { > > > - UINT8 ClassIdentifier[10]; > > > + UINT8 ClassIdentifier[11]; > > > UINT8 ArchitecturePrefix[5]; > > > UINT8 ArchitectureType[5]; > > > UINT8 Lit3[1]; > > > -- > > > 2.6.6 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > [email protected] > > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
