On Thu, Aug 11, 2016 at 12:08:15PM +0200, Ard Biesheuvel wrote:
> This moves the asm files in OpenPlatformPkg to the new ASM_FUNC() macro,
> which annotates functions in a way that allows the linker to drop code
> that is not actually used anywhere. It is analogous to -ffunction-sections
> for GCC.
> 
> Since there are some cargo culted asm patterns that are very clunky and
> inefficient, clean those up as well (i.e., LoadConstantToReg())

For the series:
Reviewed-by: Leif Lindholm <[email protected]>

> Ard Biesheuvel (6):
>   Platforms/BeagleBoard: remove unreferenced Sec.inf module
>   Platforms/BeagleBoard/BeagleBoardLib: switch to ASM_FUNC() asm macro
>   Platforms/Styx: remove unused AmdStyxSecLib
>   Platforms/Styx: switch to ASM_FUNC() asm macro
>   Platforms/Hisilicon/ArmPlatformLibPv660: switch to ASM_FUNC() asm
>     macro
>   Platforms/Marvell/Armada70x0Lib: switch to ASM_FUNC() asm macro
> 
>  Chips/Hisilicon/Library/ArmPlatformLibPv660/AArch64/Helper.S                 
>      |  44 +--
>  Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc                                 
>      |   1 -
>  Platforms/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S                       
>      |  58 ++--
>  Platforms/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf                         
>      |   7 +-
>  Platforms/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf                      
>      |   1 +
>  Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/GicV3.S                     
>      |  73 -----
>  Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/StyxBoot.S                  
>      | 182 -------------
>  Platforms/AMD/Styx/Library/AmdStyxSecLib/AmdStyxSecLib.inf                   
>      |  50 ----
>  Platforms/AMD/Styx/Library/AmdStyxSecLib/StyxSec.c                           
>      |  96 -------
>  Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc                         
>      |   1 -
>  Platforms/Marvell/Armada/Library/Armada70x0Lib/AArch64/ArmPlatformHelper.S   
>      |  32 +--
>  
> Platforms/TexasInstruments/BeagleBoard/Library/BeagleBoardLib/BeagleBoardHelper.S
>  |  16 +-
>  Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.S            
>      |  85 ------
>  Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.asm          
>      |  89 ------
>  Platforms/TexasInstruments/BeagleBoard/Sec/Cache.c                           
>      |  80 ------
>  Platforms/TexasInstruments/BeagleBoard/Sec/Clock.c                           
>      |  70 -----
>  Platforms/TexasInstruments/BeagleBoard/Sec/LzmaDecompress.h                  
>      | 103 -------
>  Platforms/TexasInstruments/BeagleBoard/Sec/PadConfiguration.c                
>      | 282 --------------------
>  Platforms/TexasInstruments/BeagleBoard/Sec/Sec.c                             
>      | 186 -------------
>  Platforms/TexasInstruments/BeagleBoard/Sec/Sec.inf                           
>      |  74 -----
>  20 files changed, 42 insertions(+), 1488 deletions(-)
>  delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/GicV3.S
>  delete mode 100644 
> Platforms/AMD/Styx/Library/AmdStyxSecLib/AArch64/StyxBoot.S
>  delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/AmdStyxSecLib.inf
>  delete mode 100644 Platforms/AMD/Styx/Library/AmdStyxSecLib/StyxSec.c
>  delete mode 100644 
> Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.S
>  delete mode 100644 
> Platforms/TexasInstruments/BeagleBoard/Sec/Arm/ModuleEntryPoint.asm
>  delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Cache.c
>  delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Clock.c
>  delete mode 100644 
> Platforms/TexasInstruments/BeagleBoard/Sec/LzmaDecompress.h
>  delete mode 100644 
> Platforms/TexasInstruments/BeagleBoard/Sec/PadConfiguration.c
>  delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Sec.c
>  delete mode 100644 Platforms/TexasInstruments/BeagleBoard/Sec/Sec.inf
> 
> -- 
> 2.7.4
> 
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to