Reviewed-by: Liming Gao <[email protected]>

> -----Original Message-----
> From: Ard Biesheuvel [mailto:[email protected]]
> Sent: Friday, August 12, 2016 2:21 AM
> To: [email protected]; [email protected]; [email protected]; Gao,
> Liming <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Subject: [PATCH 2/3] BaseTools RVCT: ignore various RVC diagnostics
> 
> This updates the RVCT CC flags so various diagnostics that trigger
> warnings-as-errors are silenced. In particular, RVCT complains about
> missing newlines at the end of source files, mixing of enums and int
> values and return statements followed by a break, all of which occur
> in the Tianocore codebase, but none of which are actual errors in the
> code. So just silence them.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 2002c4c0598b..e3d70133caaa 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -7449,7 +7449,7 @@ RELEASE_XCODE5_X64_CC_FLAGS   = -target
> x86_64-pc-win32-macho -c    -Os       -W
> 
> ##########################################################
> ##########################
> 
>  DEFINE RVCT_ALL_ASM_FLAGS   = --diag_suppress=1786 --
> diag_error=warning --apcs /interwork
> -DEFINE RVCT_ALL_CC_FLAGS    = --c90 --no_autoinline --asm --gnu --apcs
> /interwork --signed_chars --no_unaligned_access --split_sections --
> enum_is_int --preinclude AutoGen.h --diag_suppress=186 --diag_warning
> 167 --diag_error=warning --diag_style=ide --protect_stack
> +DEFINE RVCT_ALL_CC_FLAGS    = --c90 --no_autoinline --asm --gnu --apcs
> /interwork --signed_chars --no_unaligned_access --split_sections --
> enum_is_int --preinclude AutoGen.h --diag_suppress=186,188,1,111,68 --
> diag_warning 167 --diag_error=warning --diag_style=ide --protect_stack
>  DEFINE RVCT_ALL_DLINK_FLAGS = --no_scanlib --no_exceptions --
> datacompressor off --strict --symbols --diag_style=ide --no_legacyalign --
> scatter $(EDK_TOOLS_PATH)/Scripts/Rvct-Align32.sct
> 
> 
> ##########################################################
> ##########################
> --
> 2.7.4

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to