> > Actually, you don't need to retry the UDP configuration loop according
> > the Ip4Mode.IsConfigured flag. You are only recommended to set a timer
> > to check the mapping status after the configuration:
> >
> > For example:
> > Status = Nlc->Udp4->Configure(Nlc->Udp4, &Nlc->UdpConfig);
> > if (EFI_ERROR (Status) && (Status != EFI_NO_MAPPING)) {
> > return Status;
> > }
> > if (Status == EFI_NO_MAPPING && !UdpGetMapping (Nlc->Udp4)) {
> > return Status;
> > }
> >
> > In UdpGetMapping () function, create one timer to check
> > Ip4Mode.IsConfigured:
> >
> > For example:
> > UdpGetMapping () {
> > IsMapDone = FALSE;
> > gBS->CreateEvent (EVT_TIMER, TPL_CALLBACK, NULL, NULL,
> > &TimeoutEvent);
> > gBS->SetTimer (TimeoutEvent, TimerRelative, AnyValue);
> > while (EFI_ERROR (gBS->CheckEvent (TimeoutEvent))) {
> > Udp4->Poll (Udp4);
> > Udp4->GetModeData (Udp4, &Udp4Mode, & Ip4Mode, NULL, NULL);
> > if (Ip4Mode.IsConfigured) {
> > IsMapDone = TRUE;
> > break;
> > }
> > }
> > return IsMapDone;
> > }
> >
> > If DHCP process succeed, Ip4Mode.IsConfigured should be updated. If
> > not, any bug may be existed.
>
> In testing the new patch (removing RECONFIG=TRUE) I see that the
> statement you made above is not accurate when the protocol is TCP. When
> Configure is called the first time it returns EFI_NO_MAPPING. This seems to
> be remembered in the socket state: ((Sock)->ConfigureState ==
> SO_NO_MAPPING) so that any attempt to use the instance after
> Ip4Mode.IsConfigured goes TRUE fails (like for a TCP4 Listen).
>
> So for TCP we must issue another Configure request to clean up this state so
> it's not as simple as just polling the GetModeData result, at least for TCP.
Yeah. When I was drafting the UDP APP to test the new fix, I found the same
case you mentioned. We must issue another UDP Configure () to clean the
previous state once the Ip4Mode.IsConfigured is TRUE. So, the above example is
not accurate with my the current implementation:(. But I'm still not recommend
to loop the UDP configuration every time if Ip4Mode.IsConfigured is false. The
right behavior for UDP/TCP is 1) timer check the Ip4Mode.IsConfigured, 2) Once
Ip4Mode.IsConfigured is TRUE, reconfigure the instance again. Sorry for the
above example was troubling you. Also use UDP as example, correct as below:
Udata.UseDefaultAddress = TRUE;
Status = Udp4->Configure (Udp4, &Udata);
if (EFI_ERROR (Status) && (Status != EFI_NO_MAPPING)) {
return Status;
}
if ((Status == EFI_NO_MAPPING) && !UdpGetMapping (Udp4, &Udata)) {
return Status;
}
In UdpGetMapping () function:
BOOLEAN
UdpGetMapping (
IN EFI_UDP4_PROTOCOL *Udp4,
IN EFI_UDP4_CONFIG_DATA *UdpCfgData
)
{
EFI_STATUS Status;
EFI_EVENT TimeoutEvent;
EFI_IP4_MODE_DATA Ip4ModeData;
BOOLEAN IsMapDone;
IsMapDone = FALSE;
ZeroMem (&Ip4ModeData, sizeof (EFI_IP4_MODE_DATA));
Status = gBS->CreateEvent (EVT_TIMER, TPL_CALLBACK, NULL, NULL,
&TimeoutEvent);
if (EFI_ERROR (Status)) {
return IsMapDone;
}
//
// Start the timer, it will timeout after 5 seconds.
//
gBS->SetTimer (TimeoutEvent, TimerRelative, 500000000);
while (EFI_ERROR (gBS->CheckEvent (TimeoutEvent))) {
Udp4->Poll (Udp4);
if (!EFI_ERROR (Udp4->GetModeData (Udp4, NULL, &Ip4ModeData, NULL, NULL)) &&
Ip4ModeData.IsConfigured) {
Udp4->Configure (Udp4, NULL);
IsMapDone = (BOOLEAN) (Udp4->Configure (Udp4, UdpCfgData) == EFI_SUCCESS);
break;
}
}
gBS->CloseEvent (TimeoutEvent);
return IsMapDone;
}
>
> Do you believe this is expected behavior?
>
> Thanks,
>
> Eugene
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
