Reviewed-by: Feng Tian <[email protected]> -----Original Message----- From: Fan, Jeff Sent: Friday, August 19, 2016 11:09 AM To: [email protected] Cc: Tian, Feng <[email protected]>; Bi, Dandan <[email protected]> Subject: [Patch v5] UefiCpuPkg/MpInitLib: MicrocodeData used but maybe uninitialized
Cc: Feng Tian <[email protected]> Cc: Dandan Bi <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan <[email protected]> --- UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c index 0fd8e8c..5bb0145 100644 --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c @@ -92,6 +92,7 @@ MicrocodeDetect ( PlatformId = (UINT8) PlatformIdMsr.Bits.PlatformId; LatestRevision = 0; + MicrocodeData = NULL; MicrocodeEnd = (UINTN) (MicrocodePatchAddress + MicrocodePatchRegionSize); MicrocodeEntryPoint = (CPU_MICROCODE_HEADER *) (UINTN) MicrocodePatchAddress; do { @@ -198,6 +199,7 @@ MicrocodeDetect ( // Revision. A processor with no loaded update is considered to have a // revision equal to zero. // + ASSERT (MicrocodeData != NULL); AsmWriteMsr64 ( MSR_IA32_BIOS_UPDT_TRIG, (UINT64) (UINTN) MicrocodeData -- 2.7.4.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
