This reverts commit 95fc5a877502a6e6324300eed0136243d359fa96.
The above commit causes several regression of "echo" command:
1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 
section 3.4.5 chops out the quotes.
2. Output redirection is not working as expected. Text is being redirected, but 
the �> �� text should not be.
3. Inconsistent special character handling.  For example, comments with # seem 
to be parsed out correctly, but handing of ^ is incorrect.
In summary, �echo �You are ^#1� > t.txt� results in the below content in t.txt:
 �You are ^#1� > t.txt

Ruiyu Ni (3):
  Revert "ShellPkg: Fix echo to support displaying special characters"
  Revert "ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib"
  Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to
    ShellCommandLib"

 ShellPkg/Application/Shell/Shell.c                 |  81 +++++---
 ShellPkg/Application/Shell/Shell.h                 |  18 ++
 .../Application/Shell/ShellParametersProtocol.c    | 160 +++++++++++++-
 .../Application/Shell/ShellParametersProtocol.h    |  29 +++
 ShellPkg/Include/Library/ShellCommandLib.h         |  68 ------
 .../UefiShellCommandLib/UefiShellCommandLib.c      | 230 ---------------------
 ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c | 141 +++++++------
 .../UefiShellLevel3CommandsLib.uni                 |   3 +-
 8 files changed, 339 insertions(+), 391 deletions(-)

-- 
2.9.0.windows.1

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to