On Wed, Sep 07, 2016 at 08:04:50AM +0100, Ard Biesheuvel wrote: > The ArmGicLib API function GicGetCpuRedistributorBase () declares > GicCpuRedistributorBase to iterate over the redistributors of all > CPUs, but then inadvertently advances GicRedistributorBase instead. > > Reported-by: "Oliyil Kunnil, Vishal" <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <[email protected]>
Right, so I was contemplating a minor rewrite of the gic driver to make this sort of thing less likely in the future ... but quickly realised it wouldn't be a minor one. So: Reviewed-by: Leif Lindholm <[email protected]> > --- > ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c > b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > index 73795ed4e56c..e658e9bff5d8 100644 > --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c > +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c > @@ -76,7 +76,7 @@ GicGetCpuRedistributorBase ( > } > > // Move to the next GIC Redistributor frame > - GicRedistributorBase += GicRedistributorGranularity; > + GicCpuRedistributorBase += GicRedistributorGranularity; > } > > // The Redistributor has not been found for the current CPU > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
