Reviewed-by: Liming Gao <[email protected]> > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, September 08, 2016 5:10 PM > To: [email protected] > Cc: Gao, Liming <[email protected]>; Dong, Eric <[email protected]> > Subject: [patch] MdeModulePkg/UiApp: Fix incorrect question id > > For a question, its question id can not be zero. > This patch is to fix the issue that using zero as question id. > > Cc: Liming Gao <[email protected]> > Cc: Eric Dong <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <[email protected]> > --- > MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 3 > ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > index 93f6e4e..1505ef9 100644 > --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > +++ > b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > @@ -41,10 +41,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF > ANY KIND, EITHER EXPRESS OR IMPLIED. > #define UI_HII_DRIVER_LIST_SIZE 0x8 > > #define FRONT_PAGE_KEY_CONTINUE 0x1000 > #define FRONT_PAGE_KEY_RESET 0x1001 > #define FRONT_PAGE_KEY_LANGUAGE 0x1002 > +#define FRONT_PAGE_KEY_DRIVER 0x2000 > > typedef struct { > EFI_STRING_ID PromptId; > EFI_STRING_ID HelpId; > EFI_STRING_ID DevicePathId; > @@ -654,11 +655,11 @@ UiListThirdPartyDrivers ( > StartOpCodeHandle, > 0, > gHiiDriverList[Index].PromptId, > gHiiDriverList[Index].HelpId, > 0, > - 0, > + (EFI_QUESTION_ID) (Index + FRONT_PAGE_KEY_DRIVER), > 0, > &gHiiDriverList[Index].FormSetGuid, > gHiiDriverList[Index].DevicePathId > ); > > -- > 1.9.5.msysgit.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
