Ray: I have some comments. 1) This is the incompatible change in BootLogoLib. It also impacts OvmfPkg and ArmVirtPkg. Please highlight this change in cover letter, and update OvmfPkg and ArmVirtPkg both. 2) HiiDrawImageIdEx() directly calls HiiDrawImageId(). But, HiiDrawImageId() doesn't support JPEG and PNG. This is a functional issue in HiiDrawImageIdEx(). 3) IGetImage() will call Decoder protocol to get the output ImageOut. Per UEFI spec, ImageOut is allocated by Decoder protocol, and free by the caller. Please free it in IGetImage()
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, September 23, 2016 4:25 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 00/13] Add HiiImageEx implementation and > demonstrate in Nt32 > > The total 13 commits can be reviewed in following url: > https://github.com/niruiyu/edk2/commits/HiiImage > > Ruiyu Ni (13): > MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress > MdeModulePkg/HiiDatabase: Move common code to LocatePackageList() > MdeModulePkg/HiiDatabase: Refine HiiNewImage() > MdeModulePkg/HiiDatabase: Refine HiiGetImage() > MdeModulePkg/HiiDatabase: Refine HiiSetImage() > MdeModulePkg/HiiDatabase: Refine HiiDrawImage() > MdemodulePkg/HiiDatabase: Correct typo in comments. > MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG > MdeModulePkg/HiiDatabase: Add HiiImageEx implementation. > Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo > MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in > parameters > MdeModulePkg/Logo: Add LogoDxe module > Nt32Pkg: Use the new LogoDxe driver > > MdeModulePkg/Include/Library/BootLogoLib.h | 19 +- > MdeModulePkg/Include/Protocol/PlatformLogo.h | 18 +- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 204 +++---- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 6 +- > MdeModulePkg/Logo/Logo.c | 156 ++++++ > MdeModulePkg/Logo/Logo.idf | 18 + > MdeModulePkg/Logo/LogoDxe.inf | 60 ++ > MdeModulePkg/Logo/LogoDxe.uni | 21 + > MdeModulePkg/Logo/LogoDxeExtra.uni | 19 + > .../HiiDatabaseDxe/ConfigKeywordHandler.c | 36 +- > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 58 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 16 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 32 +- > .../Universal/HiiDatabaseDxe/HiiDatabase.h | 292 +++++++++- > .../Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | 7 +- > .../Universal/HiiDatabaseDxe/HiiDatabaseEntry.c | 34 +- > MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 619 ++++++++++--- > -------- > MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c | 397 > +++++++++++++ > .../PlatformBootManagerLib/PlatformBootManager.c | 4 +- > Nt32Pkg/Nt32Pkg.dsc | 7 +- > Nt32Pkg/Nt32Pkg.fdf | 5 +- > 21 files changed, 1432 insertions(+), 596 deletions(-) > create mode 100644 MdeModulePkg/Logo/Logo.c > create mode 100644 MdeModulePkg/Logo/Logo.idf > create mode 100644 MdeModulePkg/Logo/LogoDxe.inf > create mode 100644 MdeModulePkg/Logo/LogoDxe.uni > create mode 100644 MdeModulePkg/Logo/LogoDxeExtra.uni > create mode 100644 MdeModulePkg/Universal/HiiDatabaseDxe/ImageEx.c > > -- > 2.9.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
