Zhu Yonghong, Thanks for the RB on the first patch in that series.
Your patch: https://lists.01.org/pipermail/edk2-devel/2016-October/002507.html [Patch] BaseTools: Extend FMP to support FV statement and FD statement is a better solution to the OUTPUT_DIRECTORY issue, so I am dropping https://lists.01.org/pipermail/edk2-devel/2016-October/002481.html [Patch 2/2] BaseTools/GenFds: Skip parse time OUTPUT_DIRECTORY file verify Thanks, Mike > -----Original Message----- > From: Zhu, Yonghong > Sent: Tuesday, October 11, 2016 9:13 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Cc: Steele, Kelly <kelly.ste...@intel.com>; Gao, Liming > <liming....@intel.com>; Zhu, > Yonghong <yonghong....@intel.com> > Subject: RE: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order > > This patch is fine to me. > > Reviewed-by: Yonghong Zhu <yonghong....@intel.com> > > Best Regards, > Zhu Yonghong > > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, October 08, 2016 5:33 AM > To: edk2-devel@lists.01.org > Cc: Steele, Kelly <kelly.ste...@intel.com>; Zhu, Yonghong > <yonghong....@intel.com>; > Gao, Liming <liming....@intel.com> > Subject: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order > > https://bugzilla.tianocore.org/show_bug.cgi?id=141 > > This patch updates EDK II FDF parser in GenFds to allow sections to be placed > in any > order in the FDF file. > > Cc: Kelly Steele <kelly.ste...@intel.com> > Cc: Yonghong Zhu <yonghong....@intel.com> > Cc: Liming Gao <liming....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney <michael.d.kin...@intel.com> > --- > BaseTools/Source/Python/GenFds/FdfParser.py | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) > > diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py > b/BaseTools/Source/Python/GenFds/FdfParser.py > index 02ae7c9..693128c 100644 > --- a/BaseTools/Source/Python/GenFds/FdfParser.py > +++ b/BaseTools/Source/Python/GenFds/FdfParser.py > @@ -1385,25 +1385,10 @@ class FdfParser: > > try: > self.Preprocess() > - while self.__GetFd(): > - pass > - > - while self.__GetFv(): > - pass > - > - while self.__GetFmp(): > - pass > - > - while self.__GetCapsule(): > - pass > - > - while self.__GetVtf(): > - pass > - > - while self.__GetRule(): > - pass > - > - while self.__GetOptionRom(): > + # > + # Keep processing sections of the FDF until no new sections or a > syntax > error is found > + # > + while self.__GetFd() or self.__GetFv() or self.__GetFmp() or > self.__GetCapsule() or self.__GetVtf() or self.__GetRule() or > self.__GetOptionRom(): > pass > > except Warning, X: > -- > 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
