Sounds good! Thanks to confirm that. From: Carsey, Jaben Sent: Thursday, October 13, 2016 5:04 AM To: Yao, Jiewen <[email protected]>; Ni, Ruiyu <[email protected]>; Rothman, Michael A <[email protected]>; Kinney, Michael D <[email protected]>; '[email protected]' <[email protected]> Cc: Tian, Feng <[email protected]>; Zhang, Chao B <[email protected]>; Gao, Liming <[email protected]>; Zeng, Star <[email protected]>; Carsey, Jaben <[email protected]> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.
I agree. We should move the 3 protocols from the UEFI Shell Specification from ShellPkg to MdePkg. I think that this is a non-backwards-compatible-change and will require a new GUID in ShellPkg. -Jaben From: Yao, Jiewen Sent: Tuesday, October 11, 2016 7:45 AM To: Ni, Ruiyu <[email protected]<mailto:[email protected]>>; Carsey, Jaben <[email protected]<mailto:[email protected]>>; Rothman, Michael A <[email protected]<mailto:[email protected]>>; Kinney, Michael D <[email protected]<mailto:[email protected]>>; '[email protected]' <[email protected]<mailto:[email protected]>> Cc: Tian, Feng <[email protected]<mailto:[email protected]>>; Zhang, Chao B <[email protected]<mailto:[email protected]>>; Gao, Liming <[email protected]<mailto:[email protected]>>; Zeng, Star <[email protected]<mailto:[email protected]>> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application. Importance: High Yes, I think that is a very good idea. Shell spec defines EFI_SHELL_PROTOCOL, EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL, EFI_SHELL_PARAMETERS_PROTOCOL. These should be treated as industry stand and we can move these 3 to MdePkg. SHELL_ENVIRONMENT_2_PROTOCOL and SHELL_INTERFACE_PROTOCOL should be still in ShellPkg, since it is not standard. Thank you Yao Jiewen From: Ni, Ruiyu Sent: Tuesday, October 11, 2016 4:28 PM To: Carsey, Jaben <[email protected]<mailto:[email protected]>>; Rothman, Michael A <[email protected]<mailto:[email protected]>>; Yao, Jiewen <[email protected]<mailto:[email protected]>>; Kinney, Michael D <[email protected]<mailto:[email protected]>>; '[email protected]' <[email protected]<mailto:[email protected]>> Cc: Tian, Feng <[email protected]<mailto:[email protected]>>; Zhang, Chao B <[email protected]<mailto:[email protected]>>; Gao, Liming <[email protected]<mailto:[email protected]>>; Zeng, Star <[email protected]<mailto:[email protected]>> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application. Jaben, The reason I propose to move the Shell protocol definitions to MdePkg is that all applications that wants to use the ARGV can use the ShellParameter protocol, without depending on ShellPkg. Thanks/Ray From: Ni, Ruiyu Sent: Tuesday, October 11, 2016 4:08 PM To: Carsey, Jaben <[email protected]<mailto:[email protected]>>; Rothman, Michael A <[email protected]<mailto:[email protected]>>; Yao, Jiewen <[email protected]<mailto:[email protected]>>; Kinney, Michael D <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> Cc: Tian, Feng <[email protected]<mailto:[email protected]>>; Zhang, Chao B <[email protected]<mailto:[email protected]>>; Gao, Liming <[email protected]<mailto:[email protected]>>; Zeng, Star <[email protected]<mailto:[email protected]>> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application. Jaben, How about moving the contents in ShellPkg\Include\Protocol\ to MdePkg\Include\Protocol\? All industry standard protocols are defined in MdePkg, except the Shell related protocols. Thanks/Ray _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
