Hi, Giri,

Sure, I'll fix the typo.  Thank you for the review!

-Maurice

-----Original Message-----
From: Mudusuru, Giri P 
Sent: Wednesday, October 12, 2016 6:56 PM
To: Ma, Maurice; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: RE: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons 
position independent

Thanks for fixing the bug Maurice. Please fix the typo funcitons in the title 
during checkin

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> 

> -----Original Message-----
> From: Ma, Maurice
> Sent: Wednesday, October 12, 2016 6:03 PM
> To: edk2-devel@lists.01.org
> Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen 
> <jiewen....@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>
> Subject: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons 
> position independent
> 
> The current AsmGetFspInfoHeader function in FspHeader.nasm is position 
> dependent code since it uses absolute address. Change to use relative 
> address instead to make it position independent.
> 
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Giri P Mudusuru <giri.p.mudus...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Maurice Ma <maurice...@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm
> index a848dcbc0298..ad631943e32d 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm
> @@ -31,7 +31,7 @@ ASM_PFX(NextInstruction):
>     pop   eax
>     sub   eax, ASM_PFX(NextInstruction)
>     add   eax, ASM_PFX(AsmGetFspInfoHeader)
> -   sub   eax, dword [ASM_PFX(FspInfoHeaderRelativeOff)]
> +   sub   eax, dword [eax - ASM_PFX(AsmGetFspInfoHeader) +
> ASM_PFX(FspInfoHeaderRelativeOff)]
>     ret
> 
>  global ASM_PFX(AsmGetFspInfoHeaderNoStack)
> --
> 1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to