Thanks! I will use this subject.
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Friday, October 14, 2016 8:22 PM > To: Gao, Liming <liming....@intel.com>; edk2-de...@ml01.01.org > Subject: Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update > InterlockedCompareExchange64.nasm > > On 10/14/16 08:47, Liming Gao wrote: > > Remove extra qword in nasm code to make it pass build. > > This file is only built in INTEL ICC compiler. So, there is missing > > build check for it. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Liming Gao <liming....@intel.com> > > --- > > .../BaseSynchronizationLib/Ia32/InterlockedCompareExchange64.nasm > | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > > index ee63ff7..206de40 100644 > > --- > a/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > > +++ > b/MdePkg/Library/BaseSynchronizationLib/Ia32/InterlockedCompareExchan > ge64.nasm > > @@ -41,7 +41,7 @@ ASM_PFX(InternalSyncCompareExchange64): > > mov edx, [esp + 20] > > mov ebx, [esp + 24] > > mov ecx, [esp + 28] > > - lock cmpxchg8b qword [esi] > > + lock cmpxchg8b [esi] > > pop ebx > > pop esi > > ret > > > > Suggested subject line: > > MdePkg BaseSynchronizationLib InterlockedCompareExchange64: fix ICC > build > > (73 characters) > > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
