Is this required to be a patch series? By that I mean that they need to be committed in order...
Reviewed-by: Jaben Carsey <[email protected]> > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, October 19, 2016 12:52 AM > To: Gary Lin <[email protected]>; [email protected] > Cc: Carsey, Jaben <[email protected]> > Subject: RE: [PATCH 30/33] ShellPkg: Fix typos in comments and variables > Importance: High > > > > Reviewed-by: Ruiyu Ni <[email protected]> > > -----Original Message----- > > From: Gary Lin [mailto:[email protected]] > > Sent: Wednesday, October 19, 2016 3:02 PM > > To: [email protected] > > Cc: Carsey, Jaben <[email protected]>; Ni, Ruiyu > <[email protected]> > > Subject: [PATCH 30/33] ShellPkg: Fix typos in comments and variables > > > > - funciton -> function > > - paramter -> parameter > > - supresses -> suppresses > > - Seperator -> Separator > > - permenant -> permanent > > > > Cc: Jaben Carsey <[email protected]> > > Cc: Ruiyu Ni <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Lin <[email protected]> > > --- > > ShellPkg/Include/Library/ShellCEntryLib.h | > > 2 +- > > ShellPkg/Include/Library/ShellCommandLib.h | > > 2 +- > > ShellPkg/Include/Protocol/EfiShellEnvironment2.h | > > 2 +- > > ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c | > > 2 +- > > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | > > 10 > +++++- > > ---- > > > > > ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib > > .c | 2 +- > > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | > > 8 > > ++++---- > > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c | > > 8 > > ++++---- > > 8 files changed, 18 insertions(+), 18 deletions(-) > > > > diff --git a/ShellPkg/Include/Library/ShellCEntryLib.h > > b/ShellPkg/Include/Library/ShellCEntryLib.h > > index dfbb16f..e4983f8 100644 > > --- a/ShellPkg/Include/Library/ShellCEntryLib.h > > +++ b/ShellPkg/Include/Library/ShellCEntryLib.h > > @@ -1,5 +1,5 @@ > > /** @file > > - Provides application point extension for "C" style main funciton. > > + Provides application point extension for "C" style main function. > > > > Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR> > > This program and the accompanying materials diff --git > > a/ShellPkg/Include/Library/ShellCommandLib.h > > b/ShellPkg/Include/Library/ShellCommandLib.h > > index 3ee8200..5ff1e4f 100644 > > --- a/ShellPkg/Include/Library/ShellCommandLib.h > > +++ b/ShellPkg/Include/Library/ShellCommandLib.h > > @@ -2,7 +2,7 @@ > > Provides interface to shell internal functions for shell commands. > > > > This library is for use ONLY by shell commands linked into the shell > > application. > > - This library will not funciton if it is used for UEFI Shell 2.0 > > Applications. > > + This library will not function if it is used for UEFI Shell 2.0 > > Applications. > > > > Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR> > > (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> diff - > - > > git a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > > b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > > index 1aa1b7e..ac6c6a0 100644 > > --- a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > > +++ b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h > > @@ -124,7 +124,7 @@ GUID for the shell environment2 extension (main > > GUID above). > > @param[in] ParentImageHandle Handle of the image executing this > > operation. > > @param[in] CommandLine The string command line to execute. > > @param[in] DebugOutput TRUE indicates that errors should be > printed > > directly. > > - FALSE supresses error messages. > > + FALSE suppresses error messages. > > > > @retval EFI_SUCCESS The command line executed and completed. > > @retval EFI_ABORTED The operation aborted. > > diff --git a/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > > b/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > > index 525c1f1..faed230 100644 > > --- a/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > > +++ b/ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.c > > @@ -1,5 +1,5 @@ > > /** @file > > - Provides application point extension for "C" style main funciton > > + Provides application point extension for "C" style main function > > > > Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.<BR> > > This program and the accompanying materials diff --git > > a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > index 00a4c10..e07304c 100644 > > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > @@ -130,7 +130,7 @@ IsDriverProt ( > > > > @param[in] TheHandle The handles to show info on. > > @param[in] Language Language string per UEFI specification. > > - @param[in] Seperator Separator string between information blocks. > > + @param[in] Separator Separator string between information blocks. > > @param[in] Verbose TRUE for extra info, FALSE otherwise. > > @param[in] ExtraInfo TRUE for extra info, FALSE otherwise. > > > > @@ -141,7 +141,7 @@ CHAR16* > > GetProtocolInfoString( > > IN CONST EFI_HANDLE TheHandle, > > IN CONST CHAR8 *Language, > > - IN CONST CHAR16 *Seperator, > > + IN CONST CHAR16 *Separator, > > IN CONST BOOLEAN Verbose, > > IN CONST BOOLEAN ExtraInfo > > ) > > @@ -169,7 +169,7 @@ GetProtocolInfoString( > > if (Temp != NULL) { > > ASSERT((RetVal == NULL && Size == 0) || (RetVal != NULL)); > > if (Size != 0) { > > - StrnCatGrow(&RetVal, &Size, Seperator, 0); > > + StrnCatGrow(&RetVal, &Size, Separator, 0); > > } > > StrnCatGrow(&RetVal, &Size, L"%H", 0); > > StrnCatGrow(&RetVal, &Size, Temp, 0); @@ -185,7 +185,7 @@ > > GetProtocolInfoString( > > StrnCatGrow(&RetVal, &Size, Temp, 0); > > StrnCatGrow(&RetVal, &Size, L")\r\n", 0); > > } else { > > - StrnCatGrow(&RetVal, &Size, Seperator, 0); > > + StrnCatGrow(&RetVal, &Size, Separator, 0); > > StrnCatGrow(&RetVal, &Size, Temp, 0); > > } > > FreePool(Temp); > > @@ -201,7 +201,7 @@ GetProtocolInfoString( > > } > > > > ASSERT((RetVal == NULL && Size == 0) || (RetVal != NULL)); > > - StrnCatGrow(&RetVal, &Size, Seperator, 0); > > + StrnCatGrow(&RetVal, &Size, Separator, 0); > > return (RetVal); > > } > > > > diff --git > > > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > > Lib.c > > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > > Lib.c > > index 1491ee9..7948e53 100644 > > --- > > > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > > Lib.c > > +++ > > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Command > > +++ sLib.c > > @@ -99,7 +99,7 @@ ShellLevel2CommandsLibConstructor ( > > ShellCommandRegisterCommandName(L"vol", ShellCommandRunVol > , > > ShellCommandGetManFileNameLevel2, 2, L"", TRUE, > gShellLevel2HiiHandle, > > STRING_TOKEN(STR_GET_HELP_VOL) ); > > > > // > > - // support for permenant (built in) aliases > > + // support for permanent (built in) aliases > > // > > ShellCommandRegisterAlias(L"rm", L"del"); > > ShellCommandRegisterAlias(L"ls", L"dir"); diff --git > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > > index 38625fe..70d9d9a 100644 > > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c > > @@ -1492,7 +1492,7 @@ ShellCommandRunPing ( > > } > > > > // > > - // Parse the paramter of count number. > > + // Parse the parameter of count number. > > // > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-n"); > > if (ValueStr != NULL) { > > @@ -1510,7 +1510,7 @@ ShellCommandRunPing ( > > SendNumber = DEFAULT_SEND_COUNT; > > } > > // > > - // Parse the paramter of buffer size. > > + // Parse the parameter of buffer size. > > // > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-l"); > > if (ValueStr != NULL) { > > @@ -1532,7 +1532,7 @@ ShellCommandRunPing ( > > ZeroMem (&DstAddress, sizeof (EFI_IPv6_ADDRESS)); > > > > // > > - // Parse the paramter of source ip address. > > + // Parse the parameter of source ip address. > > // > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-s"); > > if (ValueStr == NULL) { > > @@ -1553,7 +1553,7 @@ ShellCommandRunPing ( > > } > > } > > // > > - // Parse the paramter of destination ip address. > > + // Parse the parameter of destination ip address. > > // > > NonOptionCount = ShellCommandLineGetCount(ParamPackage); > > if (NonOptionCount < 2) { > > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > > index 90a2604..265258f 100644 > > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c > > @@ -1177,7 +1177,7 @@ ShellCommandRunPing6 ( > > BufferSize = 16; > > > > // > > - // Parse the paramter of count number. > > + // Parse the parameter of count number. > > // > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-n"); > > ValueStrPtr = ValueStr; > > @@ -1194,7 +1194,7 @@ ShellCommandRunPing6 ( > > } > > } > > // > > - // Parse the paramter of buffer size. > > + // Parse the parameter of buffer size. > > // > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-l"); > > ValueStrPtr = ValueStr; > > @@ -1215,7 +1215,7 @@ ShellCommandRunPing6 ( > > ZeroMem (&DstAddress, sizeof (EFI_IPv6_ADDRESS)); > > > > // > > - // Parse the paramter of source ip address. > > + // Parse the parameter of source ip address. > > // > > ValueStr = ShellCommandLineGetValue (ParamPackage, L"-s"); > > ValueStrPtr = ValueStr; > > @@ -1229,7 +1229,7 @@ ShellCommandRunPing6 ( > > } > > } > > // > > - // Parse the paramter of destination ip address. > > + // Parse the parameter of destination ip address. > > // > > NonOptionCount = ShellCommandLineGetCount(ParamPackage); > > ValueStr = ShellCommandLineGetRawValue (ParamPackage, > > (UINT32)(NonOptionCount-1)); > > -- > > 2.10.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
