A combination of Jordon's and Andrews proposal would be better so we have one flag and also scalable. Level of deprecated interfaces can be controlled by each platform. EDK2 master platforms should not define this flag to eliminate the usage of deprecated interfaces while UDK2015 can define and set the value to 2015 for compatibility.
ENABLE_UDK_DEPRECATED_INTERFACES=2014 or 2015 or 2017 (UDK versions) Thanks, -Giri > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Yao, > Jiewen > Sent: Friday, October 21, 2016 4:13 PM > To: Laszlo Ersek <[email protected]>; Justen, Jordan L > <[email protected]>; Andrew Fish <[email protected]> > Cc: Kinney, Michael D <[email protected]>; edk2-devel-01 <edk2- > [email protected]>; Gao, Liming <[email protected]>; Leif Lindholm > <[email protected]>; Ard Biesheuvel <[email protected]> > Subject: Re: [edk2] [Bug 164] Add the build option "/D > DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files > > I remember our deprecation process is: > > 1) Core defines DISABLE_NEW_DEPRECATED_INTERFACES and puts a > deprecated content in it. (Platform does not use > DISABLE_NEW_DEPRECATED_INTERFACES and deprecated function can still be > used at this moment. But we strongly recommend a platform doing clean up at > same time.) > > 2) Platform defines DISABLE_NEW_DEPRECATED_INTERFACES and > deprecated function cannot be used after the clean up work. > > 3) Core removes the deprecated content and > DISABLE_NEW_DEPRECATED_INTERFACES, if we can make sure no platform > using it. > > 4) Platform may remove DISABLE_NEW_DEPRECATED_INTERFACES. > > We do not want to remove a function directly, to break lots of platforms. We > just want to give a buffer to let platform do code cleanup. > > Thank you > Yao Jiewen > > From: edk2-devel [mailto:[email protected]] On Behalf Of Laszlo > Ersek > Sent: Saturday, October 22, 2016 6:31 AM > To: Justen, Jordan L <[email protected]>; Andrew Fish > <[email protected]> > Cc: Kinney, Michael D <[email protected]>; edk2-devel-01 <edk2- > [email protected]>; Leif Lindholm <[email protected]>; Gao, Liming > <[email protected]>; Ard Biesheuvel <[email protected]> > Subject: Re: [edk2] [Bug 164] Add the build option "/D > DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files > > On 10/22/16 00:10, Jordan Justen wrote: > > On 2016-10-21 14:02:44, Laszlo Ersek wrote: > > >> Honestly, I imagined that DISABLE_NEW_DEPRECATED_INTERFACES would > be > >> temporary in the edk2 tree. That is, it's a means so we can gradually > >> transition with all the in-tree stuff to a deprecationless code base. > >> Once that's done -- i.e., *all* platform DSCs within the edk2 tree > >> specify this feature test macro under their respective [BuildOptions] > >> sections --, then whatever the macro excises from the core packages can > >> be removed permanently, together with those platform [BuildOptions]. > >> > > > > That could be reasonable, although I'd argue that we could flip it > > around. Opt-in to the deprecated interfaces on all platforms, and then > > start marking deprecated interfaces. Finally we could clean up > > platforms and removed the override. > > That's a valid idea, IMO. > > > But ... I think DISABLE_NEW_DEPRECATED_INTERFACES was first added in: > > > > commit bf4a3dbd4751b6411bdfc98bf3ac2c4f928bdfdf > > Author: ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524> > > Date: Wed May 30 07:36:00 2012 +0000 > > > > So, I guess it is not going to be removed anytime soon. :( > > I believe we just need to make progress with the individual platforms > (and their dependencies from other Pkgs). It's not a lot of fun, but the > BZs exist (well, they can be filed) now, and then we can address them... > > I mean, I didn't care (or, really, know) about > DISABLE_NEW_DEPRECATED_INTERFACES until the ArmVirtPkg / OvmfPkg BZs > got > filed. Bugzilla is great. I like the attention that it gets, from others > and from myself. > > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > [email protected]<mailto:[email protected]> > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
