Hi Pete, I see the new INF files uses '..' in the [Sources] section, which is not allowed. Can we move that INF file up one directory, so it can remove use of ..?
I also see that this code defined its own EFI_EBC_DEBUGGER_CODE macro. Could these be changed to the standard DEBUG_CODE() macro that can be enabled and disabled with a PCD? Or do you think we should add a new Feature Flag PCD to enable/disable the EBC debugger? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Pete > Batard > Sent: Friday, November 11, 2016 7:51 AM > To: [email protected] > Subject: [edk2] [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger > > The EBC Debugger [1], which was present in Tianocore [2], is an > invaluable tool for EBC development. > This patch adds it back into the EDK2, allowing, for instance, the > compilation of an AARCH64 EBC debugger. > > Note 1: The patch is split in two, so that the changes to the existing > EbcDxe code are clearer. > > Note 2: The diff between the original and the new sources can be found > at [3]. Most of the changes were for whitespaces/API names/compiler > warnings, with the notable exception of: > - Bumping of the EBCdebugger version to 1.0. > - Dropping of the DebuggerConfiguration protocol (which would require > introducing a new global GUID and protocol). I didn't see it as > particularly useful to caary on and would rather see if there is actual > demand for it, before adding it back. > - Add of an EFIAPI qualifier for most of the support functions, > especially the ones dealing with VPrint() ouput. This is required to > avoid garbage text output in some instances. > - Fixing of the erroneous display of 32 and 64 bit indexes in the > disassembly. > - Replacement of one assignation with CopyMem() to avoid an intrinsic > memcpy(). > > Note 3: I tested the debugger built for AARCH64 and X64 using gcc on > Linux (Debian/Sid) as well as the one built for IA32 and X64 using > VS2015 on Windows. I haven't tested an IA64 version for lack of a toolchain. > > Regards, > > /Pete > > [1] http://www.uefi.org/node/550 > [2] https://github.com/tianocore/edk/tree/master/Sample/Universal/Ebc/Dxe > [3] > https://github.com/pbatard/EbcDebugger/commit/906e87ed6ceab1c361ba6f681bef48179ba > f549e > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
