> On Nov 15, 2016, at 8:59 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 11/15/16 09:32, Jeff Fan wrote: >> SecCoreData->StackBase is VOID * type and SecCoreData->StackSize is UINTN >> type. >> We should use %x to dump their value instead of %lx. >> >> Cast pointer type to UINTN before print it. >> >> Cc: Feng Tian <feng.t...@intel.com> >> Cc: Michael D Kinney <michael.d.kin...@intel.com> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jeff Fan <jeff....@intel.com> >> --- >> UefiCpuPkg/SecCore/SecMain.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/UefiCpuPkg/SecCore/SecMain.c b/UefiCpuPkg/SecCore/SecMain.c >> index 2ebbc22..4d08f48 100644 >> --- a/UefiCpuPkg/SecCore/SecMain.c >> +++ b/UefiCpuPkg/SecCore/SecMain.c >> @@ -239,9 +239,9 @@ SecStartupPhase2( >> >> DEBUG (( >> DEBUG_INFO, >> - "%a() Stack Base: 0x%lx, Stack Size: 0x%lx\n", >> + "%a() Stack Base: 0x%x, Stack Size: 0x%x\n", >> __FUNCTION__, >> - SecCoreData->StackBase, >> + (UINTN) SecCoreData->StackBase, >> SecCoreData->StackSize >> )); >> >> > > Not disagreeing, just mentioning for completeness: we can also use %p > for printing (VOID*) directly. >
%x is sizeof(int) not sizeof(UINTN)? So it seems %p would be more correct? Or we should just use UINT32 if that is what is intended. https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/PrintLib.h#L80 - x - The argument is an unsigned hexadecimal number. The characters used are 0..9 and A..F. If the flag 'L' is not specified, then the argument is assumed to be size int. This does not follow ANSI C. Thanks, Andrew Fish > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel > <https://lists.01.org/mailman/listinfo/edk2-devel> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
