On 11/30/16 18:20, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Nevertheless, new code should be using the MdeModulePkg versions, so
> change all references in in-tree platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>
> ---
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc | 4 ++--
> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 6 +++---
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 13 files changed, 27 insertions(+), 27 deletions(-)
[snip]
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index d913030..81f7521 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -505,7 +505,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> -
> NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -550,7 +550,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> -
> NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 8143ea9..f7855b6 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -513,7 +513,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> -
> NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -559,7 +559,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> -
> NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index d48d603..e933a41 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -512,7 +512,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> -
> NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -557,7 +557,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> -
> NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +
> NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
[snip]
I diffed the two library instances (the directories) recursively, and
they are identical. That's actually too much of a match for my taste;
the copy under MdeModulePkg should have at least received a different
FILE_GUID.
Anyway, the change looks safe. If you split out the OvmfPkg patch
(please do that in the non-RFC version), you can add my
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
