Reviewed-by: Ruiyu Ni <[email protected]> Regards, Ray
>-----Original Message----- >From: Wu, Hao A >Sent: Friday, January 6, 2017 4:51 PM >To: [email protected] >Cc: Wu, Hao A <[email protected]>; Ni, Ruiyu <[email protected]> >Subject: [PATCH] FatPkg: Explicitly declare FAT_CLUSTER_SPECIAL as unsigned >type > >In FatPkg, cluster-related varibles are declared as unsigned type (e.g. >UINT32/UINTN). To keep the comparisions involving those variables >type-matched, declare the definition FAT_CLUSTER_SPECIAL as unsigned type >explicitly. > >Cc: Ruiyu Ni <[email protected]> >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Hao Wu <[email protected]> >--- > FatPkg/EnhancedFatDxe/FatFileSystem.h | 4 ++-- > FatPkg/FatPei/FatLiteFmt.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/FatPkg/EnhancedFatDxe/FatFileSystem.h >b/FatPkg/EnhancedFatDxe/FatFileSystem.h >index a4d4405..80cb802 100644 >--- a/FatPkg/EnhancedFatDxe/FatFileSystem.h >+++ b/FatPkg/EnhancedFatDxe/FatFileSystem.h >@@ -1,7 +1,7 @@ > /** @file > Definitions for on-disk FAT structures. > >-Copyright (c) 2005, Intel Corporation. All rights reserved.<BR> >+Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials are licensed and made available > under the terms and conditions of the BSD License which accompanies this > distribution. The full text of the license may be found at >@@ -26,7 +26,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >EXPRESS OR IMPLIED. > // > // FAT entry values > // >-#define FAT_CLUSTER_SPECIAL_EXT (-1 & (~0xF)) >+#define FAT_CLUSTER_SPECIAL_EXT (MAX_UINTN & (~0xF)) > #define FAT_CLUSTER_SPECIAL ((FAT_CLUSTER_SPECIAL_EXT) | 0x07) > #define FAT_CLUSTER_FREE 0 > #define FAT_CLUSTER_RESERVED (FAT_CLUSTER_SPECIAL) >diff --git a/FatPkg/FatPei/FatLiteFmt.h b/FatPkg/FatPei/FatLiteFmt.h >index d4f26f3..9872200 100644 >--- a/FatPkg/FatPei/FatLiteFmt.h >+++ b/FatPkg/FatPei/FatLiteFmt.h >@@ -1,7 +1,7 @@ > /** @file > FAT format data structures > >-Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR> >+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR> > > This program and the accompanying materials are licensed and made available > under the terms and conditions of the BSD License which accompanies this >@@ -27,7 +27,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >EXPRESS OR IMPLIED. > #define FAT_ATTR_ARCHIVE 0x20 > #define FAT_ATTR_LFN (FAT_ATTR_READ_ONLY | > FAT_ATTR_HIDDEN | FAT_ATTR_SYSTEM | >FAT_ATTR_VOLUME_ID) > >-#define FAT_CLUSTER_SPECIAL ((-1 &~0xF) | 0x7) >+#define FAT_CLUSTER_SPECIAL ((MAX_UINT32 &~0xF) | 0x7) > #define FAT_CLUSTER_FREE 0 > #define FAT_CLUSTER_RESERVED (FAT_CLUSTER_SPECIAL) > #define FAT_CLUSTER_BAD (FAT_CLUSTER_SPECIAL) >-- >1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
