Looks good. Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
I had one inline question. I would also propose that the String to GUID conversion be placed in a shared library. Maybe even baselib with the other string functions? Mike, do you have any thoughts on StringToGuid conversion? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Monday, January 9, 2017 1:31 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and > "decode" parameter > Importance: High > > Change "dh" to support dump from GUID and "decode" parameter > > Chen A Chen (2): > ShellPkg/HandleParsingLib: Add new API GetAllMappingGuids > ShellPkg/Dh: Fix coding style issues > > Ruiyu Ni (3): > ShellPkg/HandleParsingLib: Rename global variables > ShellPkg/HandleParsingLib: Return NULL name for unknown GUID > ShellPkg/dh: Support dump from GUID and "decode" parameter > > ShellPkg/Include/Library/HandleParsingLib.h | 21 +- > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 130 ++++-- > .../UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +- > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 458 +++++++++++++++-- > ---- > .../UefiShellDriver1CommandsLib.uni | 9 +- > 5 files changed, 446 insertions(+), 176 deletions(-) > > -- > 2.9.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
