Reviewed-by: Feng Tian <[email protected]> Thanks Feng
-----Original Message----- From: Wu, Hao A Sent: Friday, January 6, 2017 4:52 PM To: [email protected] Cc: Wu, Hao A <[email protected]>; Tian, Feng <[email protected]>; Zeng, Star <[email protected]>; Kinney, Michael D <[email protected]> Subject: [PATCH] MdeModulePkg/Stall: Refine to compare 2 values with the same type Cc: Feng Tian <[email protected]> Cc: Star Zeng <[email protected]> Cc: Michael Kinney <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu <[email protected]> --- MdeModulePkg/Core/Dxe/Misc/Stall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/Misc/Stall.c b/MdeModulePkg/Core/Dxe/Misc/Stall.c index 73e9078..95a5615 100644 --- a/MdeModulePkg/Core/Dxe/Misc/Stall.c +++ b/MdeModulePkg/Core/Dxe/Misc/Stall.c @@ -1,7 +1,7 @@ /** @file UEFI Miscellaneous boot Services Stall service implementation -Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -67,7 +67,7 @@ CoreStall ( // Counter = Microseconds * 10 / gMetronome->TickPeriod // 0x1999999999999999 = (2^64 - 1) / 10 // - if (Microseconds > 0x1999999999999999ULL) { + if ((UINT64) Microseconds > 0x1999999999999999ULL) { // // Microseconds is too large to multiple by 10 first. Perform the divide // operation first and loop 10 times to avoid 64-bit math overflow. -- 1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
