Commit version: https://github.com/tianocore/edk2/commit/7be6e6776253d3638f03375e346e978228af5edb
Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary > Lin > Sent: Monday, January 16, 2017 2:30 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> > Subject: [edk2] [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the > ChooseFile handler > > The ChooseFile handler, UpdateCAFromFile, has to be EFIAPI or gcc would > use the wrong ABI and cause the crash of the firmware. This commit also > removes the unnecessary type casting in ChooseFile. > > Cc: Siyuan Fu <siyuan...@intel.com> > Cc: Jiaxin Wu <jiaxin...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin <g...@suse.com> > --- > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > index 5f04503887..fedfb01be9 100644 > --- a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > +++ b/NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c > @@ -1218,6 +1218,7 @@ UpdatePage( > @retval FALSE Not exit caller function. > **/ > BOOLEAN > +EFIAPI > UpdateCAFromFile ( > IN EFI_DEVICE_PATH_PROTOCOL *FilePath > ) > @@ -1728,7 +1729,7 @@ TlsAuthConfigAccessCallback ( > CleanUpPage (LabelId, Private); > break; > case KEY_TLS_AUTH_CONFIG_ENROLL_CERT_FROM_FILE: > - ChooseFile( NULL, NULL, (CHOOSE_HANDLER) UpdateCAFromFile, &File); > + ChooseFile( NULL, NULL, UpdateCAFromFile, &File); > break; > > case KEY_TLS_AUTH_CONFIG_VALUE_SAVE_AND_EXIT: > -- > 2.11.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
