On Tue, Jan 17, 2017 at 09:13:23PM +0100, Laszlo Ersek wrote: > On 01/17/17 09:25, Jordan Justen wrote: > > On 2017-01-16 20:52:29, Gary Lin wrote: > >> This series adjusts the build files of OVMF in order to support HTTPS. > >> It introdues a new build option, TLS_ENABLE, and makes OpenSSL a hard > >> requirement to enable IPv6 support. > >> > >> Gary Lin (3): > >> OvmfPkg: always resolve OpenSslLib, IntrinsicLib and BaseCryptLib > > > > Ok. I see that OpenSSL will still not be a dependency, unless one of > > the dependent features is enabled. (And, they are all disabled by > > default.) > > > > Series Reviewed-by: Jordan Justen <[email protected]> > > > > But, I'll let Laszlo take a look too. > > My sincere apologies to you and Qin Long for missing your R-b tags. > > In retrospect, the Received headers in those messages are consistent > with the Date fields, so the messages did arrive in time (before my > commit / response) in my IMAP inbox. I must have missed them for one of > two reasons: > > - my local OfflineIMAP sync glitched out temporarily (unlikely!), or > - these messages appeared only in my edk2-devel list folder, and not in > my INBOX (likely). > > In order to decrease the likelihood of such mess-ups on my end in the > future, Gary, can you please ensure that you copy the complete set of > Cc: tags from across the patches to the blurb? This is good for two > goals: first, everyone CC'd on at least one patch will understand the > big picture from the blurb; second, feedback from people who (correctly) > hit "Reply All" on the blurb will reach everyone else too. > > (I recommend this practice in > <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23>, > under the last bullet.) > My bad. I forgot to edit the cc list in the cover letter. Will do that next time.
Thanks, Gary Lin > Nonetheless, missing this feedback is my fault; I should have waited a > bit longer, and double-checked the list folder right before pushing. I'm > sorry! > > Laszlo > > > Thanks, > > > > -Jordan > > > >> OvmfPkg: correct the set of modules included for the IPv6 stack > >> OvmfPkg: pull in TLS modules with -D TLS_ENABLE (also enabling HTTPS) > >> > >> OvmfPkg/OvmfPkgIa32.dsc | 29 ++++++++++++++++------------- > >> OvmfPkg/OvmfPkgIa32.fdf | 8 ++++---- > >> OvmfPkg/OvmfPkgIa32X64.dsc | 29 ++++++++++++++++------------- > >> OvmfPkg/OvmfPkgIa32X64.fdf | 8 ++++---- > >> OvmfPkg/OvmfPkgX64.dsc | 29 ++++++++++++++++------------- > >> OvmfPkg/OvmfPkgX64.fdf | 8 ++++---- > >> 6 files changed, 60 insertions(+), 51 deletions(-) > >> > >> -- > >> 2.11.0 > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> [email protected] > >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
