MdeModulePkg reviewed-by: Feng Tian <[email protected]> -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Laszlo Ersek Sent: Thursday, January 19, 2017 6:30 PM To: Zeng, Star <[email protected]>; [email protected] <[email protected]>; Kinney, Michael D <[email protected]>; Fan, Jeff <[email protected]>; Tian, Feng <[email protected]>; Ni, Ruiyu <[email protected]>; Ma, Maurice <[email protected]>; Agyeman, Prince <[email protected]>; Steele, Kelly <[email protected]>; Leif Lindholm <[email protected]> Cc: Gao, Liming <[email protected]>; Ard Biesheuvel <[email protected]> Subject: Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public
Hi Star, On 01/19/17 11:27, Zeng, Star wrote: > Hi, > > Please kindly help take a review to the patches. :) > > So far, I have got the RB from Liming and Ard to MdePkg and ArmPlatformPkg. I didn't ignore the series, it's just that I don't co-maintain any of the packages being modified. Thanks Laszlo > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 17, 2017 3:09 PM > To: [email protected] > Cc: Zeng, Star <[email protected]>; Gao, Liming > <[email protected]>; Kinney, Michael D > <[email protected]>; Fan, Jeff <[email protected]>; Tian, > Feng <[email protected]>; Ni, Ruiyu <[email protected]>; Ma, > Maurice <[email protected]>; Agyeman, Prince > <[email protected]>; Steele, Kelly <[email protected]>; > Leif Lindholm <[email protected]>; Ard Biesheuvel > <[email protected]>; Laszlo Ersek <[email protected]> > Subject: [PATCH 0/7] Make the event empty function in UefiLib public > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298 > > We found there are many event empty functions in EDK2 code base, these > patches are to make the event empty function in UefiLib public, then this > event empty function can be used to remove the duplication in drivers and > other libraries. > > In CorebootPayloadPkg/QuarkPlatformPkg/ArmPlatformPkg, EfiEventGroupSignal > from UefiLib can be used to remove the duplication of event empty function. > > Cc: Liming Gao <[email protected]> > Cc: Michael Kinney <[email protected]> > Cc: Jeff Fan <[email protected]> > Cc: Feng Tian <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Cc: Maurice Ma <[email protected]> > Cc: Prince Agyeman <[email protected]> > Cc: Kelly Steele <[email protected]> > Cc: Leif Lindholm <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Laszlo Ersek <[email protected]> > > Star Zeng (7): > MdePkg UefiLib: Make the event empty function public > IntelFrameworkPkg UefiLib: Make the event empty function public > MdeModulePkg: Use EfiEventEmptyFunction from UefiLib > IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib > CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib > QuarkPlatformPkg: Use EfiEventGroupSignal from UefiLib > ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib > > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 ++----------------- > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 3 +- > .../PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 3 +- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > .../Universal/BdsDxe/BdsEntry.c | 20 +---------- > .../Library/FrameworkUefiLib/UefiLib.c | 42 > +++++++++++----------- > .../Library/FrameworkUefiLib/UefiLibInternal.h | 20 +---------- > .../Library/FrameworkUefiLib/UefiNotTiano.c | 4 +-- > MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 23 ++---------- > MdeModulePkg/Core/Dxe/DxeMain.h | 18 +--------- > MdeModulePkg/Core/Dxe/Event/Event.c | 4 +-- > MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c | 19 ++-------- > .../Universal/Console/ConSplitterDxe/ConSplitter.c | 22 ++---------- > .../Universal/Console/ConSplitterDxe/ConSplitter.h | 18 +--------- > .../Universal/DriverSampleDxe/DriverSample.c | 20 ++--------- > .../Universal/SetupBrowserDxe/Presentation.c | 20 ++--------- > MdePkg/Include/Library/UefiLib.h | 18 +++++++++- > MdePkg/Library/UefiLib/UefiLib.c | 42 > +++++++++++----------- > MdePkg/Library/UefiLib/UefiLibInternal.h | 20 +---------- > MdePkg/Library/UefiLib/UefiNotTiano.c | 10 +++--- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > 21 files changed, 91 insertions(+), 321 deletions(-) > > -- > 2.7.0.windows.1 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
