On 19.01.2017 11:22, Zeng, Star wrote: > With the typo "explicitely" fixed in the commit log,
Oh, right, stupid me ;-) Could you maybe fix that when picking up the patch (since I can't commit this on my own)? Or shall I rather resend the patch? Thanks, Thomas > Reviewed-by: Star Zeng <[email protected]> > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Thomas > Huth > Sent: Thursday, January 19, 2017 6:16 PM > To: [email protected] > Cc: Tian, Feng <[email protected]>; Zeng, Star <[email protected]> > Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements > > If the code eventually returns "Status" anyway, it does not make sense to > explicitely return "Status" in case of an error, too. > (this patch has been created with Coccinelle) > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Thomas Huth <[email protected]> > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 --- > MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 --- > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 --- > 4 files changed, 12 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > index 51cff3c..ad6cdb1 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > @@ -1046,9 +1046,6 @@ NvmeControllerInit ( > // One for blocking I/O, one for non-blocking I/O. > // > Status = NvmeCreateIoSubmissionQueue (Private); > - if (EFI_ERROR(Status)) { > - return Status; > - } > > return Status; > } > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > index 3f73194..9dbec10 100755 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > @@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed ( > > HsTiming = 1; > Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming, > ClockFreq); > - if (EFI_ERROR (Status)) { > - return Status; > - } > > return Status; > } > diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > index d6d3bdb..5a9e0b2 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > @@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed ( > > HsTiming = 1; > Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq); > - if (EFI_ERROR (Status)) { > - return Status; > - } > > return Status; > } > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index 7ef141f..01bec19 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart ( > // > Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL); > ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR > (EFI_MAGENTA, EFI_BLACK)); > - if (EFI_ERROR (Status)) { > - return Status; > - } > > return Status; > } > -- > 1.8.3.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
