I agree to remove it. -----Original Message----- From: Zeng, Star Sent: Wednesday, February 22, 2017 9:23 AM To: Duran, Leo; Fan, Jeff; 'edk2-de...@ml01.01.org'; Tian, Feng Cc: Yao, Jiewen; Zeng, Star Subject: RE: UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c)
Leo, Seemingly, you are right that no one is using SetCacheability(). Jeff, Could you confirm that? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Duran, Leo Sent: Wednesday, February 22, 2017 5:44 AM To: 'edk2-de...@ml01.01.org' <edk2-de...@ml01.01.org>; Tian, Feng <feng.t...@intel.com> Cc: Zeng, Star <star.z...@intel.com> Subject: [edk2] UefiCpuPkg: PiSmmCpuDxeSmm (MpServioce.c) Hi Feng, et al, I'm wondering if the SetCacheability() function has been deprecated from the build tree? That is, the function is part of MpService.c, but it does not seem to be used by any other code. Would be it be OK to remove SetCacheability() from MpService.c? I ask because I'm preparing a patch for code that touches page-table entries, and I'd prefer to simply ignore/remove SetCacheability(), if it's not needed anymore. Thanks, Leo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
