Ok to me as well. Reviewed-by: Feng Tian <[email protected]>
Thanks Feng -----Original Message----- From: Zeng, Star Sent: Monday, March 20, 2017 10:16 AM To: Laszlo Ersek <[email protected]>; edk2-devel-01 <[email protected]> Cc: Ard Biesheuvel <[email protected]>; Tian, Feng <[email protected]>; Wu, Hao A <[email protected]>; Leif Lindholm <[email protected]>; Zeng, Star <[email protected]> Subject: RE: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages I am ok with this patch. Feng and Hao, do you have any comments? Thanks, Star -----Original Message----- From: Laszlo Ersek [mailto:[email protected]] Sent: Saturday, March 18, 2017 4:47 AM To: edk2-devel-01 <[email protected]> Cc: Ard Biesheuvel <[email protected]>; Tian, Feng <[email protected]>; Wu, Hao A <[email protected]>; Leif Lindholm <[email protected]>; Zeng, Star <[email protected]> Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages RamDiskDxe installs the RamDiskAcpiCheck() Ready To Boot callback function. If EFI_ACPI_TABLE_PROTOCOL and/or EFI_ACPI_SDT_PROTOCOL are not found, then informational messages are logged, and the RAM disks are not published to the (nonexistent) NFIT table. The logic is fine, but the info messages are not concatenated correctly from multiple string literals -- the second parts are passed as (unused) arguments to DEBUG(). Fix the typos. Cc: Ard Biesheuvel <[email protected]> Cc: Feng Tian <[email protected]> Cc: Hao Wu <[email protected]> Cc: Leif Lindholm <[email protected]> Cc: Star Zeng <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <[email protected]> --- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c index d1dd13a8197b..b2bafc58bb71 100644 --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c @@ -74,7 +74,7 @@ RamDiskAcpiCheck ( if (EFI_ERROR (Status)) { DEBUG (( EFI_D_INFO, - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol,", + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol, " "unable to publish RAM disks to NFIT.\n" )); return; @@ -91,7 +91,7 @@ RamDiskAcpiCheck ( if (EFI_ERROR (Status)) { DEBUG (( EFI_D_INFO, - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol,", + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol, " "unable to publish RAM disks to NFIT.\n" )); mAcpiTableProtocol = NULL; -- 2.9.3 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
