Reviewed-by: Liming Gao <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Yonghong Zhu > Sent: Wednesday, May 24, 2017 5:39 PM > To: [email protected] > Cc: Gao, Liming <[email protected]> > Subject: [edk2] [Patch] BaseTools: Correct if condition expression for > DatumType == 'VOID*' > > Correct the if condition expression for DatumType == 'VOID*'. Current > this condition is not work since the DatumType is changed before we do > the value judgement. > > Cc: Liming Gao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yonghong Zhu <[email protected]> > --- > BaseTools/Source/Python/AutoGen/GenC.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/GenC.py > b/BaseTools/Source/Python/AutoGen/GenC.py > index ae191d8..67aaef7 100644 > --- a/BaseTools/Source/Python/AutoGen/GenC.py > +++ b/BaseTools/Source/Python/AutoGen/GenC.py > @@ -1224,11 +1224,11 @@ def CreateLibraryPcdCode(Info, AutoGenC, AutoGenH, > Pcd): > AutoGenH.Append('extern const %s _gPcd_FixedAtBuild_%s%s;\n' > %(DatumType, TokenCName, Array)) > AutoGenH.Append('#define %s %s_gPcd_FixedAtBuild_%s\n' > %(GetModeName, Type, TokenCName)) > AutoGenH.Append('//#define %s ASSERT(FALSE) // It is not allowed > to set value for a FIXED_AT_BUILD PCD\n' % > SetModeName) > > if PcdItemType == TAB_PCDS_FIXED_AT_BUILD and (key in Info.ConstPcd > or (Info.IsLibrary and not > Info._ReferenceModules)): > - if DatumType == 'VOID*': > + if Pcd.DatumType == 'VOID*': > AutoGenH.Append('#define _PCD_VALUE_%s %s%s\n' %(TokenCName, > Type, PcdVariableName)) > else: > AutoGenH.Append('#define _PCD_VALUE_%s %s\n' %(TokenCName, > Pcd.DefaultValue)) > > if PcdItemType == TAB_PCDS_FIXED_AT_BUILD: > -- > 2.6.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
