On 05/25/17 20:56, Jordan Justen wrote: > On 2017-05-25 10:58:45, Laszlo Ersek wrote: >> >> If you add a patch to the series where you change the DEPEX of >> PciHostBridgeDxe to >> >> gEdkiiIoMmuProtocolGuid OR gEdkiiIoMmuAbsentProtocolGuid >> >> then the maintainer (Ray or Jiewen I think) will likely reject that >> patch, because afterwards, all platforms that include PciHostBridgeDxe >> would suddenly have to produce gEdkiiIoMmuAbsentProtocolGuid, minimally. > > I haven't worked with it, but it does appear that feature PCD's can be > used to conditionally add new depex values. > > $ git grep -e '|.*Pcd' -- '*.inf'
I've now reviewed the result list for this search, and none of the results are contained in a [Depex] section actually. They are all under [Protocols], [Guids], or [Pcd] -- there doesn't seem to be an example for a FeaturePCD-dependent DEPEX. > I'm not sure if that feature works with depex 'OR'. > > Regarding IoMmuAbsent or IoMmuDetectionAttempted, they seem similar. Right, I'm fine with either. Thanks, Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
