Seems quite straight forward to me.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shah, Tapan
> Sent: Thursday, June 08, 2017 8:55 AM
> To: Hegde, Nagaraj P <nagaraj-p.he...@hpe.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu
> <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin
> <jiaxin...@intel.com>
> Subject: Re: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
> Importance: High
> 
> Reviewed-by: Tapan Shah <tapands...@hpe.com>
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hegde, Nagaraj P
> Sent: Thursday, June 08, 2017 1:41 AM
> To: edk2-devel@lists.01.org
> Cc: jaben.car...@intel.com; ruiyu...@intel.com; siyuan...@intel.com;
> jiaxin...@intel.com
> Subject: [edk2] [PATCH v1 1/1] ShellPkg/ifconfig: Update help message
> 
> Couple of instances had IP4 mentioned, instead of IPv4.
> Changing all to IPv4 to maintain consistency.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hegde Nagaraj P <nagaraj-p.he...@hpe.com>
> ---
> 
> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm
> andsLib.uni | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> index d9bbb209cd..d427dd209f 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.uni
> @@ -150,13 +150,13 @@
>  ".SH DESCRIPTION\r\n"
>  " \r\n"
>  "NOTES:\r\n"
> -"  1. This command modifies the default IP address for the UEFI IP4\r\n"
> +"  1. This command modifies the default IP address for the UEFI IPv4\r\n"
>  "     network stack.\r\n"
>  "  2. Use '-r' to renew configuration of interface and set dhcp policy.\r\n"
>  "  3. Use '-l' to list the DNS and other address related settings for 
> all\r\n"
>  "     interfaces or the specified interface.\r\n"
>  "  4. Use '-s <Name> static <IP> <SubnetMask> <GatewayMask>' with \r\n"
> -"     static IP4 address configuration for specified interface.\r\n"
> +"     static IPv4 address configuration for specified interface.\r\n"
>  "  5. Use '-s <Name> dhcp' for DHCP4 to request the IP4 address\r\n"
>  "     configuration dynamically for specified interface.\r\n"
>  "  6. Use '-s <Name> dns <IP>' must under manual policy.\r\n"
> --
> 2.13.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to