Yes. I will remove it before checking in the codes. Thanks. Regards, Dandan -----Original Message----- From: Zeng, Star Sent: Monday, June 19, 2017 12:55 PM To: Bi, Dandan <[email protected]>; [email protected] Cc: Ni, Ruiyu <[email protected]>; Gao, Liming <[email protected]>; Zeng, Star <[email protected]> Subject: RE: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments
Just found below comments in MdePkg.dec, should it be removed also? ## ## In UEFI 2.6 spec,this guid value is duplicate with ## EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to ## avoid the duplicate guid issue. So its value is not consistent with ## UEFI spec definition now. We have proposed to update UEFI spec to ## use this new guid. After new spec released, we will remove this ## comments. ## Thanks, Star -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Dandan Bi Sent: Monday, June 19, 2017 12:46 PM To: [email protected] Cc: Ni, Ruiyu <[email protected]>; Gao, Liming <[email protected]> Subject: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments Cc: Liming Gao <[email protected]> Cc: Ruiyu Ni <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <[email protected]> --- MdePkg/Include/Protocol/HiiImageDecoder.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/MdePkg/Include/Protocol/HiiImageDecoder.h b/MdePkg/Include/Protocol/HiiImageDecoder.h index 48a1a97..34eb5e1 100644 --- a/MdePkg/Include/Protocol/HiiImageDecoder.h +++ b/MdePkg/Include/Protocol/HiiImageDecoder.h @@ -16,19 +16,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #ifndef __HII_IMAGE_DECODER_H__ #define __HII_IMAGE_DECODER_H__ #include <Protocol/HiiImage.h> - -// -// In UEFI 2.6 spec,this guid value is duplicate with -// EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to -// avoid the duplicate guid issue. So its value is not consistent with -// UEFI spec definition now. We have proposed to update UEFI spec to -// use this new guid. After new spec released, we will remove this -// comments. -// #define EFI_HII_IMAGE_DECODER_PROTOCOL_GUID \ {0x9e66f251, 0x727c, 0x418c, { 0xbf, 0xd6, 0xc2, 0xb4, 0x25, 0x28, 0x18, 0xea }} #define EFI_HII_IMAGE_DECODER_NAME_JPEG_GUID \ -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
