Hi Leif, sorry for the delay in replying, got sidetracked by other issues. > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: 05 June 2017 18:11 > To: Scott Telford <stelf...@cadence.com> > Cc: edk2-de...@ml01.01.org; ard.biesheu...@linaro.org; > graeme.greg...@linaro.org; af...@apple.com; michael.d.kin...@intel.com > Subject: Re: [staging/cadence-aarch64 PATCH v2 1/6] CadencePkg: Add > libraries for Cadence CSP platform.
> > + > > + gCadenceCspTokenSpaceGuid.PcdPcie1RootPortBaseAddress > > + gCadenceCspTokenSpaceGuid.PcdPcieRootPortBaseAddress > > + gCadenceCspTokenSpaceGuid.PcdPciConfigurationSpaceBaseAddress > > + gCadenceCspTokenSpaceGuid.PcdPciConfigurationSpaceSize > > + gArmTokenSpaceGuid.PcdPciMmio32Base > > + gArmTokenSpaceGuid.PcdPciMmio32Size > > + gArmTokenSpaceGuid.PcdPciMmio64Base > > + gArmTokenSpaceGuid.PcdPciMmio64Size > > All of my comments from round 1 have been addressed, apart from the > paragraph of Pcds above probably not being needed. > That's not actually correct at the moment, but if adjusting the memory > map setup based on Ard's comments, I think these could go? Some of these are actually still required as they are used in ArmPlatformGetVirtualMemoryMap() in CadenceCspLibMem.c. Regards, Scott. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
