Hi,
On 06/20/17 03:23, Fu Siyuan wrote:
> V3 update:
> Fix X64 build error.
>
> V2 update:
> Correct the file size print for IA32.
>
> This patch updates the HTTP Boot driver to install a default HTTP Callback
> protocol
> if the platform doesn't provide one. This callback implementation will print
> the
> boot file download progress in percentage format.
This patch breaks the GCC build, because:
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> index cf6de80..56f5bab 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
> +**/
> +EFI_STATUS
> +HttpBootCallback (
> + IN EFI_HTTP_BOOT_CALLBACK_PROTOCOL *This,
> + IN EFI_HTTP_BOOT_CALLBACK_DATA_TYPE DataType,
> + IN BOOLEAN Received,
> + IN UINT32 DataLength,
> + IN VOID *Data OPTIONAL
> + )
the EFIAPI calling convention wasn't specified here, but
> +///
> +/// HTTP Boot Callback Protocol instance
> +///
> +GLOBAL_REMOVE_IF_UNREFERENCED
> +EFI_HTTP_BOOT_CALLBACK_PROTOCOL gHttpBootDxeHttpBootCallback = {
> + HttpBootCallback
> +};
it is required here, for the EFI_HTTP_BOOT_CALLBACK function pointer type.
(Reported by Gerd's Jenkins CI.)
Thanks,
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
