On 1 July 2017 at 21:04, Laszlo Ersek <[email protected]> wrote: > Ard, Leif, > > On 06/29/17 10:32, Ruiyu Ni wrote: >> Ruiyu Ni (3): >> MdePkg: Add ResetNotification protocol definition >> MdeModulePkg/ResetSystem: Remove unnecessary global variable >> MdeModulePkg/ResetSystem: Implement ResetNotification protocol >> >> .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 >> +++++++++++++++++++-- >> .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 ++- >> .../ResetSystemRuntimeDxe.inf | 5 +- >> MdePkg/Include/Protocol/ResetNotification.h | 86 ++++++++++++ >> MdePkg/MdePkg.dec | 3 + >> 5 files changed, 247 insertions(+), 14 deletions(-) >> create mode 100644 MdePkg/Include/Protocol/ResetNotification.h >> > > I think we should > - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe, > - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe > to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete > EmbeddedPkg/ResetRuntimeDxe from the tree. > > What do you guys think? >
I would happily get rid of EmbeddedPkg/ResetRuntimeDxe, given that I can't really tell why it is there in the first place. Anyone have a clue? > Other producers of gEfiResetArchProtocolGuid could be affected as well > (just from a quick grep): > - DuetPkg/AcpiResetDxe > - EmulatorPkg/ResetRuntimeDxe > - Nt32Pkg/ResetRuntimeDxe > > Thanks > Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
