On 2017-07-18 08:59:46, Kinney, Michael D wrote:
> Hi Jordan,
>
> I can update the logic. The loop of supported
> version values looks good.
>
> One of the reasons I choose the style I did is that
> this patch is intended to be short lived. I would
> like to see everyone transition to the new agreement
> in their commit messages. I know there are patches
> in progress, so we need a period of time where both
> are supported. I a month or two, I would like to
> require the 1.1 agreement in the commit messages.
>
> Adding flexibility in the compare did not make much
> sense if we are going to use one most of the time.
Oh. Good point. What about something like:
def check_contributed_under(self):
cu_msg='Contributed-under: TianoCore Contribution Agreement 1.1'
if self.msg.find(cu_msg) < 0:
# Allow 1.0 for now while EDK II community transitions to 1.1
cu_msg='Contributed-under: TianoCore Contribution Agreement 1.0'
if self.msg.find(cu_msg) < 0:
self.error('Missing Contributed-under! (Note: this must be ' +
'added by the code contributor!)')
And, maybe we could mention in the commit message that allowing 1.0 is
temporary?
With that: Reviewed-by: Jordan Justen <[email protected]>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
