Reviewed-by: Sriram Subramanian <[email protected]> -----Original Message----- From: Hegde, Nagaraj P Sent: Tuesday, August 1, 2017 11:18 AM To: [email protected] Cc: [email protected]; Subramanian, Sriram <[email protected]>; [email protected]; [email protected] Subject: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line
If DAD failed, we print "It failed to set", print the IPv6 address and exit. We need a better error string and also, after printing the IPv6 address, we need a new line else the Shell> prompt will overwrite the IPv6 address. Fixed these issues in this patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P <[email protected]> --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 2 ++ ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c index 6d8df8031b..a25d4e5d00 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c @@ -2,6 +2,7 @@ The implementation for Shell command IfConfig6. Copyright (c) 2016, Intel Corporation. All rights reserved.<BR> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo ( &CfgManAddr[Index].Address, &CfgManAddr[Index].PrefixLength ); + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_INFO_NEWLINE), gShellNetwork2HiiHandle); } } diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni index 5c0fef0ff7..ee2f28717f 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni @@ -2,6 +2,7 @@ String definitions for UEFI Shell network 2 commands Copyright (c) 2016, Intel Corporation. All rights reserved.<BR> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions @@ -92,7 +93,7 @@ "Hint: Please type 'IfConfig6 -?' for help info.\r\n" #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND #language en-US "Unknown commands. Bad command %H%s%N is skipped.\r\n" "Hint: Please type 'IfConfig6 -?' for help info.\r\n" -#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "It failed to set .\r\n" +#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "Failed to configure IPv6 address: " #string STR_GET_HELP_PING6 #language en-US "" -- 2.13.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
