Hi Laszlo, On 08/02/2017 04:24 PM, Laszlo Ersek wrote:
This series is proposed as a replacement (or a replacement "basis") for patches #1 through #3 of Brijesh's series[PATCH v1 0/4] OvmfPkg : IoMmuDxe: BusMasterCommonBuffer support when SEV is active [email protected]">http://mid.mail-archive.com/[email protected] Patch #4 of the same series ("OvmfPkg : QemuFwCfgLib: Map DMA buffer with CommonBuffer when SEV is enable") is required on top of this series; otherwise QemuFwCfgLib will break on SEV. In the present series, patches #1 through #7 are lightweight improvements for OvmfPkg/IoMmuDxe, concerning line width, MAP_INFO field names, conversion specifiers for DEBUG(), coding style, error propagation, and library class listings. Patch #8 ("zero out pages before releasing them") fixes the "information leak" issue pointed out in: [email protected]">http://mid.mail-archive.com/[email protected] Patch #9 ('rework setup of "MapInfo->PlainTextAddress" in Map()') fixes as-yet undiscussed issues, and lays the groundwork for patch #10, by reworking the calculation of the plaintext buffer address. Patch #10 ("implement in-place decryption/encryption for Map/Unmap") fixes the issues around BusMasterCommonBuffer[64] operations that were discussed in the following messages: [email protected]">http://mid.mail-archive.com/[email protected] [email protected]">http://mid.mail-archive.com/[email protected] [email protected]">http://mid.mail-archive.com/[email protected] [email protected]">http://mid.mail-archive.com/[email protected] Patch #11 ("abort harder on memory encryption mask failures") settles the error handling for MemEncryptSevClearPageEncMask() and MemEncryptSevSetPageEncMask(), discussed in: [email protected]">http://mid.mail-archive.com/[email protected] Patch #12 ("Unmap(): recycle MAP_INFO after BusMasterCommonBuffer[64]") implements the "free list" proposed in: [email protected]">http://mid.mail-archive.com/[email protected] The series has been formatted with "--function-context", for easier review. Repo: https://github.com/lersek/edk2.git Branch: amdsev_iommu_cleanups_fixes Cc: Ard Biesheuvel <[email protected]> Cc: Brijesh Singh <[email protected]> Cc: Jordan Justen <[email protected]> Cc: Tom Lendacky <[email protected]>
Appreciate your help, the series looks good. I have ran some overnight tests and so far things are looking positive. As you pointed out in blurb that we still need Patch #4 from my series. I will soon send updated version. Tested-By: Brijesh Singh <[email protected]> Reviewed-by: Brijesh Singh <[email protected]> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
