Hi Eric, The 2 new PCDs have default values of 0x10 and 0x02, but there is no description of the legal values that these 2 PCDs can have and a description of the meaning of the default value is not provided.
Also, if there is a specific legal range, then please add the @ tags to for range checks. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On > Behalf Of Eric Dong > Sent: Thursday, August 3, 2017 8:37 PM > To: [email protected] > Cc: Ni, Ruiyu <[email protected]>; Fan, Jeff > <[email protected]> > Subject: [edk2] [Patch v4 1/3] UefiCpuPkg: Add Pcds used by > processor trace feature. > > Cc: Jeff Fan <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong <[email protected]> > --- > UefiCpuPkg/UefiCpuPkg.dec | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dec > b/UefiCpuPkg/UefiCpuPkg.dec > index e5b0334..2ddeab4 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -285,5 +285,13 @@ > # @ValidList 0x80000001 | 0 > gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019 > > + ## Contains the size of memory required when CPU processor > trace is enabled. > + # @Prompt The memory size used for processor trace. > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x6 > 0000012 > + > + ## Contains the processor trace output scheme when CPU > processor trace is enabled. > + # @Prompt The processor trace output scheme. > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8| > 0x60000015 > + > [UserExtensions.TianoCore."ExtraFiles"] > UefiCpuPkgExtra.uni > -- > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
