Eric, Please add the default value settings to the detailed description.
For example, PcdCpuProcTraceMemSize should say that the default value is 0x10 which disables the processor memory trace. Also, the .uni file _HELP should contains the same information as the detailed description, including the set of valid values and their meanings. Please see gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel in MdePkg/MdePkg.uni for an example to follow. Thanks, Mike > -----Original Message----- > From: Dong, Eric > Sent: Tuesday, August 8, 2017 11:32 PM > To: [email protected] > Cc: Gao, Liming <[email protected]>; Ni, Ruiyu > <[email protected]>; Kinney, Michael D > <[email protected]> > Subject: [Patch 1/2] UefiCpuPkg: Add comments for PCDs > definition. > > Cc: Liming Gao <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Cc: Michael D Kinney <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong <[email protected]> > --- > UefiCpuPkg/UefiCpuPkg.dec | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dec > b/UefiCpuPkg/UefiCpuPkg.dec > index 2ddeab4..1f3a992 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -287,10 +287,32 @@ > > ## Contains the size of memory required when CPU processor > trace is enabled. > # @Prompt The memory size used for processor trace. > + # 0x0: 4K, > + # 0x1: 8K, > + # 0x2: 16K, > + # 0x3: 32K, > + # 0x4: 64K, > + # 0x5: 128K, > + # 0x6: 256K, > + # 0x7: 512K, > + # 0x8: 1M, > + # 0x9: 2M, > + # 0xA: 4M, > + # 0xB: 8M, > + # 0xC: 16M, > + # 0xD: 32M, > + # 0xE: 64M, > + # 0xF: 128M, > + # 0x10: ProcTraceMemDisable > + # @ValidRange 0x80000001 | 0 - 0x10 > > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0 > x60000012 > > ## Contains the processor trace output scheme when CPU > processor trace is enabled. > # @Prompt The processor trace output scheme. > + # 0: Single Range output scheme.<BR> > + # 1: ToPA(Table of physical address) scheme.<BR> > + # 2: Invalid scheme.<BR> > + # @ValidRange 0x80000001 | 0 - 2 > > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT > 8|0x60000015 > > [UserExtensions.TianoCore."ExtraFiles"] > -- > 2.10.1.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
