Thanks for the CC
On 08/10/17 15:04, Leif Lindholm wrote:
> You've reworked this to be targeted for edk2-platforms, which is
> excellent! However:
> - Please update subject line to match.
> - Please also cc edk2-devel@lists.01.org (since you are with Linaro,
> it makes sense to still cc linaro-uefi)
>
> To get the appropriate subject line for edk2-devel, as desribed by
> https://github.com/tianocore/edk2-platforms/blob/about/Readme.md it
> would also be helpful to add
> --subject-prefix="edk2-platforms/master][PATCH" to git format-patch
> command line (unless Laszlo can point out a better way of achieving
> the same).
I seem to recall a discussion (not necessarily related to the
edk2-platforms tree, but to another edk2-related tree, still posted to
edk2-devel) that we're fine if you put the tree identified right after
the PATCH word, between the same brackets. So just use
--subject-prefix="PATCH edk2-platforms/master"
or even (if "master" is quite obvious)
--subject-prefix="PATCH edk2-platforms"
>
> On Wed, Aug 09, 2017 at 10:12:36PM +0800, Jun Nie wrote:
>> Add Sanchip Zx296718 basic library files for Zx296718 SoC
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Jun Nie <jun....@linaro.org>
>> ---
>> .../Library/Zx296718EvbLib/Zx296718Evb.c | 132
>> +++++++++++++++++++++
>> .../Library/Zx296718EvbLib/Zx296718EvbHelper.S | 50 ++++++++
>> .../Library/Zx296718EvbLib/Zx296718EvbLib.inf | 53 +++++++++
>> .../Library/Zx296718EvbLib/Zx296718EvbMem.c | 107 +++++++++++++++++
>> Silicon/Sanchip/Zx296718/Include/Zx296718.h | 30 +++++
>> Silicon/Sanchip/Zx296718/Zx296718.dec | 32 +++++
>
> It is more clear (especially when submitting new ports) to generate
> the patches with --stat=1000, to make the full file paths visible.
Yes, please -- I recommend:
--stat=1000 --stat-graph-width=20
("--stat=1000" without "--stat-graph-width=20" won't be pleasant.)
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
