Got you. Thanks.

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Kinney, Michael D 
Sent: Saturday, August 12, 2017 12:33 AM
To: Zhu, Yonghong <yonghong....@intel.com>; edk2-devel@lists.01.org; Kinney, 
Michael D <michael.d.kin...@intel.com>
Cc: Gao, Liming <liming....@intel.com>
Subject: RE: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use 
with RunMakefile.py

Hi Yonghong,

The tab characters in the makefile are required.  The makefile does not run in 
all environments if they are replaced with spaces.

The makefiles generated by build also use tabs.

Mike

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Thursday, August 10, 2017 10:41 PM
> To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- 
> de...@lists.01.org
> Cc: Gao, Liming <liming....@intel.com>; Zhu, Yonghong 
> <yonghong....@intel.com>
> Subject: RE: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile 
> for use with RunMakefile.py
> 
> Hi Mike,
> 
> The patch 3 has some "Tab character used". Please fix it when you 
> commit.
> Others are good to me.
> 
> Reviewed-by: Yonghong Zhu <yonghong....@intel.com>
> 
> Best Regards,
> Zhu Yonghong
> 
> 
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Friday, August 04, 2017 1:30 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming....@intel.com>; Zhu, Yonghong 
> <yonghong....@intel.com>; Kinney, Michael D 
> <michael.d.kin...@intel.com>
> Subject: [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for 
> use with RunMakefile.py
> 
> Add sample makefile that can be used to test RunMakefile.py script and 
> can also be used as a template to start a new PREBUILD/POSTBUILD 
> makefile.
> 
> Cc: Liming Gao <liming....@intel.com>
> Cc: Yonghong Zhu <yonghong....@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney <michael.d.kin...@intel.com>
> ---
>  BaseTools/Scripts/RunMakefileSample.mak | 43
> +++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 BaseTools/Scripts/RunMakefileSample.mak
> 
> diff --git a/BaseTools/Scripts/RunMakefileSample.mak
> b/BaseTools/Scripts/RunMakefileSample.mak
> new file mode 100644
> index 0000000000..b0947b7644
> --- /dev/null
> +++ b/BaseTools/Scripts/RunMakefileSample.mak
> @@ -0,0 +1,43 @@
> +## @file
> +# Sample makefile for PREBUILD or POSTBUILD action.
> +#
> +# Copyright (c) 2017, Intel Corporation. All rights
> reserved.<BR> #
> +This program and the accompanying materials # are licensed and
> made
> +available under the terms and conditions of the BSD License
> +# which accompanies this distribution.       The full text of the
> license may be found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS
> IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +#
> +
> +all: show
> +     @echo $@
> +genc: show
> +     @echo $@
> +genmake: show
> +     @echo $@
> +modules: show
> +     @echo $@
> +libraries: show
> +     @echo $@
> +fds: show
> +     @echo $@
> +clean: show
> +     @echo $@
> +cleanall: show
> +     @echo $@
> +cleanlib: show
> +     @echo $@
> +run: show
> +     @echo $@
> +
> +show:
> +     @echo WORKSPACE........ $(WORKSPACE)
> +     @echo PACKAGES_PATH.... $(PACKAGES_PATH)
> +     @echo ACTIVE_PLATFORM.. $(ACTIVE_PLATFORM)
> +     @echo TARGET_ARCH...... $(TARGET_ARCH)
> +     @echo TOOL_CHAIN_TAG... $(TOOL_CHAIN_TAG)
> +     @echo CONF_DIRECTORY... $(CONF_DIRECTORY)
> +     @echo TARGET........... $(TARGET)
> +     @echo EXTRA_FLAGS...... $(EXTRA_FLAGS)
> --
> 2.13.1.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to