Reviewed and tested it. Looks good to me. Thanks for addressing my offline comment, Michael. :) Reviewed-by: Sunny Wang <[email protected]>
Regards, Sunny Wang -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Michael D Kinney Sent: Tuesday, August 15, 2017 6:30 AM To: [email protected] Cc: Ruiyu Ni <[email protected]>; Hao Wu <[email protected]>; Michael Kinney <[email protected]> Subject: [edk2] [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles Add STD_ERROR flag to all output consoles that the Nt32 platform supports so all messages sent to the standard error console device(s) are visible by default. The Boot Maintenance Manager can be used to manually disable standard error output to specific console devices. UEFI Applications and UEFI Drivers are recommended to be built with DEBUG() and ASSERT() messages sent to the standard error device using MdePkg/Library/UefiDebugLibStdErr. Prior to this change, a user would have to use the Boot Maintenance Manager to configure a standard error console device to make these messages visible. Cc: Ruiyu Ni <[email protected]> Cc: Hao Wu <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney <[email protected]> --- Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c index e92f377bd1..e4b400b4a3 100644 --- a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c +++ b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c @@ -2,7 +2,7 @@ Defined the platform specific device path which will be filled to ConIn/ConOut variables. -Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -137,19 +137,19 @@ NT_ISA_SERIAL_DEVICE_PATH gNtSerialDevicePath1 = { PLATFORM_CONSOLE_CONNECT_ENTRY gPlatformConsole[] = { { (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath0, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath1, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath0, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath1, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { NULL, -- 2.13.1.windows.2 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
