Laszlo, If you only change a couple of words in a sentence, it will show the differences at the work level instead of the line level. If you add/remove entire paragraphs, then you will not see any differences. I am just in the habit of always adding ?w=1 to provide the best possible review format.
I have not found a URL to auto select that view. When a single patch changes several files, you get that button for each file within the patch. Mike > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On > Behalf Of Laszlo Ersek > Sent: Tuesday, August 15, 2017 4:01 AM > To: Kinney, Michael D <[email protected]>; edk2-devel- > 01 <[email protected]> > Cc: Justen, Jordan L <[email protected]>; Leif Lindholm > <[email protected]>; Ard Biesheuvel > <[email protected]> > Subject: Re: [edk2] [edk2-CCodingStandardsSpecification PATCH > 0/2] improvements related to line wrapping > > Mike, > > On 08/11/17 19:07, Kinney, Michael D wrote: > > Laszlo, > > > > You can also provide links to the GitHub commits with "?w=1" > > flag appended. If you select the "Display the rich diff" > button > > above each changed file, GitHub renders a view with change > bars. > > > > https://github.com/lersek/edk2- > CCodingStandardsSpecification/commit/2c5534a24b15616fdaa02478858 > ed1d8908dc653?w=1 > > I opened two browser tabs with this link, one without "?w=1" and > another > with "?w=1", and compared the contents visually (by switching > back and > forth between the tabs), checking each screen-ful. I'm not > seeing any > differences. > > When I click the button that you mention, I do get a rendered > diff as > well. I wonder if this feature is javascript-only, or if it can > be > triggered with URL changes. > > Thanks > Laszlo > > > > > https://github.com/lersek/edk2- > CCodingStandardsSpecification/commit/e3797dc48316052005cefa26246 > ab2fd32641881?w=1 > > > > Best regards, > > > > Mike > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:[email protected]] > >> Sent: Friday, August 11, 2017 9:49 AM > >> To: edk2-devel-01 <[email protected]> > >> Cc: Ard Biesheuvel <[email protected]>; Justen, > Jordan L > >> <[email protected]>; Leif Lindholm > >> <[email protected]>; Kinney, Michael D > >> <[email protected]> > >> Subject: [edk2-CCodingStandardsSpecification PATCH 0/2] > >> improvements related to line wrapping > >> > >> We've discussed these ideas repeatedly over time; I'm now > >> attempting to > >> formalize them. Also test-driving the documentation > contribution > >> process. > >> > >> - Repo: https://github.com/lersek/edk2- > >> CCodingStandardsSpecification.git > >> - Branch: line_wrapping > >> - Rendered views of the pages modified: > >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- > >> coding-standards-sp/content/v/line_wrapping/#edk-ii-c-coding- > >> standards-specification > >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- > >> coding-standards- > sp/content/v/line_wrapping/5_source_files/#51- > >> general-rules > >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- > >> coding-standards- > >> sp/content/v/line_wrapping/5_source_files/52_spacing.html#52- > >> spacing > >> > >> Cc: Ard Biesheuvel <[email protected]> > >> Cc: Jordan Justen <[email protected]> > >> Cc: Leif Lindholm <[email protected]> > >> Cc: Michael D Kinney <[email protected]> > >> > >> Thanks > >> Laszlo > >> > >> Laszlo Ersek (2): > >> Source Files / General Rules: limit line lengths to 80 > columns > >> Source Files / Spacing / Multi-line func. calls: allow > >> condensed > >> arguments > >> > >> 5_source_files/52_spacing.md | 29 +++++++++++++++++++- > >> 5_source_files/README.md | 17 ++++++++---- > >> README.md | 2 ++ > >> 3 files changed, 42 insertions(+), 6 deletions(-) > >> > >> -- > >> 2.13.1.3.g8be5a757fa67 > > > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
