Reviewed-by: [email protected] > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, August 17, 2017 9:08 AM > To: [email protected] > Cc: Yao, Jiewen <[email protected]> > Subject: [patch] IntelSiliconPkg/IntelVTdDxe: Update function comments > > In commit 4ad5f597153c7cb20a968236c2c7d6ff01994350, the parameters > of some functions have been updated, but miss to update the comments > accordingly. This patch is to update the function comments. > > Cc: Jiewen Yao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <[email protected]> > --- > IntelSiliconPkg/IntelVTdDxe/DmaProtection.h | 1 + > IntelSiliconPkg/IntelVTdDxe/TranslationTable.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h > b/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h > index c3b57a0..c311b29 100644 > --- a/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h > +++ b/IntelSiliconPkg/IntelVTdDxe/DmaProtection.h > @@ -314,10 +314,11 @@ DumpSecondLevelPagingEntry ( > > /** > Set VTd attribute for a system memory. > > @param[in] VtdIndex The index used to identify a VTd > engine. > + @param[in] DomainIdentifier The domain ID of the source. > @param[in] SecondLevelPagingEntry The second level paging entry in VTd > table for the device. > @param[in] BaseAddress The base of device memory > address to be used as the DMA memory. > @param[in] Length The length of device memory > address to be used as the DMA memory. > @param[in] IoMmuAccess The IOMMU access. > > diff --git a/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c > b/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c > index 80fc823..bc0c24c 100644 > --- a/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c > +++ b/IntelSiliconPkg/IntelVTdDxe/TranslationTable.c > @@ -732,10 +732,11 @@ SplitSecondLevelPage ( > > /** > Set VTd attribute for a system memory on second level page entry > > @param[in] VtdIndex The index used to identify a VTd > engine. > + @param[in] DomainIdentifier The domain ID of the source. > @param[in] SecondLevelPagingEntry The second level paging entry in VTd > table for the device. > @param[in] BaseAddress The base of device memory > address to be used as the DMA memory. > @param[in] Length The length of device memory > address to be used as the DMA memory. > @param[in] IoMmuAccess The IOMMU access. > > @@ -815,10 +816,11 @@ SetSecondLevelPagingAttribute ( > > /** > Set VTd attribute for a system memory. > > @param[in] VtdIndex The index used to identify a VTd > engine. > + @param[in] DomainIdentifier The domain ID of the source. > @param[in] SecondLevelPagingEntry The second level paging entry in VTd > table for the device. > @param[in] BaseAddress The base of device memory > address to be used as the DMA memory. > @param[in] Length The length of device memory > address to be used as the DMA memory. > @param[in] IoMmuAccess The IOMMU access. > > -- > 1.9.5.msysgit.1
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
