(Adding linaro-uefi, since this is not official tooling.) On Fri, Aug 18, 2017 at 07:29:59PM -0400, Alan Ott wrote: > --- > edk2-build.sh | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/edk2-build.sh b/edk2-build.sh > index 60da4df..fb0cb84 100755 > --- a/edk2-build.sh > +++ b/edk2-build.sh > @@ -73,11 +73,13 @@ function do_build > import_openssl > fi > > - set_cross_compile > - CROSS_COMPILE="$TEMP_CROSS_COMPILE" > + if [ -z $CROSS_COMPILE ]; then > + set_cross_compile > + CROSS_COMPILE="$TEMP_CROSS_COMPILE" > + fi > > echo "Building $PLATFORM_NAME - $PLATFORM_ARCH" > - echo "CROSS_COMPILE=\"$TEMP_CROSS_COMPILE\"" > + echo "CROSS_COMPILE=\"$CROSS_COMPILE\"" > echo "$board"_BUILDFLAGS="'$PLATFORM_BUILDFLAGS'" > > if [ "$TARGETS" == "" ]; then
Sorry, can't accept this one. I use this script to build multiple platforms across multiple architectures in one go, and this change breaks that. But also, do you really need it? Cross compilers accessible on the PATH should be automatically detected. If you do need it, because you're using some non-standard toolchain (such as aarch64-none-eabi), I would like to see something like what exists (in semi-broken form) in uefi-build.sh: CROSS_COMPILE_32 vs CROSS_COMPILE_64. However, in order to be useful, that would need to be extended to do a per-architecture override: CROSS_COMPILE_AARCH64 CROSS_COMPILE_ARM CROSS_COMPILE_IA32 CROSS_COMPILE_X64 Regards, Leif _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
