(1) The subject line contains a super-sneaky typo which I missed in my
previous review: VIR-I-T-O vs. VIR-T-I-O.
vv
VIRITO_F_IOMMU_PLATFORM
VIRTIO_F_IOMMU_PLATFORM
^^
The code is correct.
With the subject fixed (which I plan to do):
Reviewed-by: Laszlo Ersek <[email protected]>
Thanks
Laszlo
On 08/23/17 14:22, Brijesh Singh wrote:
> This feature indicates that the device is behind an IOMMU that translates
> bus addresses from the device into physical addresses in memory. If this
> feature bit is set to 0, then the device emits physical addresses which
> are not translated further, even though an IOMMU may be present.
> see [1] for more infromation
>
> [1] https://lists.oasis-open.org/archives/virtio-dev/201610/msg00121.html
>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: Jordan Justen <[email protected]>
> Cc: Tom Lendacky <[email protected]>
> Cc: Laszlo Ersek <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Brijesh Singh <[email protected]>
> ---
> OvmfPkg/Include/IndustryStandard/Virtio10.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Include/IndustryStandard/Virtio10.h
> b/OvmfPkg/Include/IndustryStandard/Virtio10.h
> index 4c9b62a3cf59..c5efb5cfcb8a 100644
> --- a/OvmfPkg/Include/IndustryStandard/Virtio10.h
> +++ b/OvmfPkg/Include/IndustryStandard/Virtio10.h
> @@ -2,6 +2,7 @@
> Definitions from the VirtIo 1.0 specification (csprd05).
>
> Copyright (C) 2016, Red Hat, Inc.
> + Copyright (C) 2017, AMD, Inc.
>
> This program and the accompanying materials are licensed and made available
> under the terms and conditions of the BSD License which accompanies this
> @@ -81,6 +82,7 @@ typedef struct {
> //
> // VirtIo 1.0 reserved (device-independent) feature bits
> //
> -#define VIRTIO_F_VERSION_1 BIT32
> +#define VIRTIO_F_VERSION_1 BIT32
> +#define VIRTIO_F_IOMMU_PLATFORM BIT33
>
> #endif // _VIRTIO_1_0_H_
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
