On 31 August 2017 at 14:51, Leif Lindholm <[email protected]> wrote: > On 30 August 2017 at 14:26, Ard Biesheuvel <[email protected]> wrote: >> On 29 August 2017 at 18:01, Ard Biesheuvel <[email protected]> wrote: >>> On 29 August 2017 at 16:53, Marcin Wojtas <[email protected]> wrote: >>>> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel <[email protected]>: >>>>> On 29 August 2017 at 16:47, Marcin Wojtas <[email protected]> wrote: >>>>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm <[email protected]>: >>>>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>>>>> more abstract level. This allows the driver to be shared with >>>>>>>> platforms that are cache coherent (by simply switching to another >>>>>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>>>>> EDK2. >>>>>>>> >>>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>>>> Signed-off-by: Ard Biesheuvel <[email protected]> >>>>>>> >>>>>>> Ah, and there is the non-bogus fix :) >>>>>>> Reviewed-by: Leif Lindholm <[email protected]> >>>>>> >>>>>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>>>>> >>>>> >>>>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >>>>> changes (which I will do today) >>>> >>>> Ok, please let know once it's available and also it would be great if >>>> this patch could be shared via github repo. >>>> >>> >>> The prerequisite patches for DmaLib are in EDK2 now. >>> >>> https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib >> >> Note that I just updated this branch to use NonCoherentDmaLib rather >> than ArmDmaLib > > For clarity - my Reviewed-by: still applies. >
Thank. Pushed as bff9700855e43e4948fb4f7249b9a4fb5451072e _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
