On 09/04/17 17:11, Ge Song wrote: > On 09/04/2017 09:34 PM, Jordan Justen wrote: > >> On 2017-09-03 16:55:36, Laszlo Ersek wrote: >>> On 09/03/17 04:12, Ge Song wrote: >>>> In earlier PEI stage, temporary memory(Cache As Ram) is employed as >>>> stack >>>> and heap. We move them to the new room and do some relocation fixup >>>> when >>>> permanent memory becomes available. TemporaryRamMigration() >>>> is responsible for switching the stack. >>> [...] >>> >>>> Cc: Jordan Justen <jordan.l.jus...@intel.com> >>>> Cc: Laszlo Ersek <ler...@redhat.com> >>>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ge Song <ge.s...@hxt-semitech.com> >>>> --- >>>> OvmfPkg/Sec/SecMain.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>> (No more separate emails, I promise.) >>> >>> Before you send v2, can you please amend the patch like this: >>> >>> git commit --amend --author='Ge Song <ge.s...@hxt-semitech.com>' >>> >>> It's OK if you mail it out from another email address, but IMO the git >>> authorship should match the first Signed-off-by. >> I disagree with this. Unless the individual is well known to the EDK >> II community as the owner of both email addresses, I think the author >> needs to send it from their author email. >> >> I suppose they can send it from another email, and then reply from >> their other email saying they contributed it under the Tianocore >> Contribution Agreement, but that sounds like a stretch...
I'm fine either way, as long as we can establish some kind of agreement between (two of?) the three email addresses (sender, git author, S-o-b). Thanks, Laszlo > OK, I'll try to send it from the same email address next time, the reason > that using two different mail addresses is because the author email is an > exchange account and it's hard to find the mail server preferences for > git-send-email... > >> >>> The commit message body currently does not start with "From: Ge Song >>> <ge.s...@hxt-semitech.com>", which means that the git authorship and the >>> first S-o-b disagree at the moment. >>> >>> ... If I'm wrong about this, I can be convinced, of course. >>> >>> Thanks >>> Laszlo > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
