On Mon, Sep 04, 2017 at 03:03:42PM +0000, Evan Lloyd wrote: > Thanks, Leif. > > > -----Original Message----- > > From: Leif Lindholm [mailto:[email protected]] > > Sent: 01 September 2017 22:48 > > To: Evan Lloyd <[email protected]> > > Cc: [email protected]; Ard Biesheuvel <[email protected]>; > > Matteo Carlini <[email protected]>; [email protected] > > Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 > > > > On Fri, Sep 01, 2017 at 06:27:28PM +0100, [email protected] wrote: > > > From: EvanLloyd <[email protected]> > > > > > > A recent change in edk2: > > > EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures > > > actually broke the build for AARCH64 architectures (well Juno, really). > > > The PCD moved, PcdIsp1761BaseAddress, is used by > > > edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which > > was > > > included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > > > > This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it > > > doesn't invoke the PCD for Juno. > > > > Err, oops. > > > > The only explanation I can think of is that in a moment of genius I decided > > that since TC2 was the only platform using the driver, that was the only > > one I > > had to build test after the change... > > [[Evan Lloyd]] Big of you to own up. We've all been there.
Well, it's out there for everyone to see whether I own up or not :) > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Evan Lloyd <[email protected]> > > > > Reviewed-by: Leif Lindholm <[email protected]> > > > > However, would you be able to submit this under Contribution Agreement > > 1.1? (a reply stating so would be sufficient, I can fold it in before > > pushing) > > [[Evan Lloyd]] > [[Evan Lloyd]] "Err, oops." Please be so good as to accept this > assurance that I intended to use Contribution Agreement 1.1. I'll > change our template today, to prevent this happening again. Thanks - folded that change in and pushed as 6b95ac45c. (After test-building _everything_.) / Leif > > > > / > > Leif > > > > > --- > > > > > > Code may be examined at: > > > https://github.com/EvanLloyd/edk2- > > platforms/blob/148_fix_juno_build_v1 > > > /Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++--- > > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > index > > > > > 770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c974152 > > 6fc > > > 0c1b75073fa0 100644 > > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > @@ -471,9 +471,6 @@ [Components.common] > > > EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > > > !endif > > > > > > - # ISP1761 USB OTG Controller > > > - EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > > > - > > > # > > > # Android Fastboot > > > # > > > @@ -505,3 +502,9 @@ [Components.common] > > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > > > > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > > ommandLib.inf > > > } > > > + > > > +[Components.ARM] > > > + > > > + # ISP1761 USB OTG Controller > > > + EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > > > + > > > -- > > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
