On Wed, Sep 06, 2017 at 04:25:09PM +0530, Meenakshi Aggarwal wrote:
> We want to print name of the function resulted in error,
> but __FUNCTION__ macro was missing.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Meenakshi Aggarwal <[email protected]>
BaseTools/Scripts/PatchCheck.py gives a number of warnings on this
patch:
* EFI_D_ERROR was used, but DEBUG_ERROR is now recommended
Can you please address and respin. (I could do that myself, but that
now causes issues with 2/2, and that's more invasive than I like to be
when committing a patch.)
Otherwise good to go (and 2/2 is much more reviewable now).
/
Leif
> ---
> EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> index 7f74c54..8010dea 100644
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> @@ -388,12 +388,12 @@ InitializeSdMmcDevice (
>
> Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status));
> + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD55): Error and Status = %r\n",
> __FUNCTION__, Status));
> return Status;
> }
> Status = MmcHost->ReceiveResponse (MmcHost, MMC_RESPONSE_TYPE_R1,
> Response);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n", Status));
> + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD55): Error and Status = %r\n",
> __FUNCTION__, Status));
> return Status;
> }
> if ((Response[0] & MMC_STATUS_APP_CMD) == 0) {
> @@ -445,12 +445,12 @@ InitializeSdMmcDevice (
> CmdArg |= 1 << (0 * 4);
> Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, CmdArg);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", Status));
> + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD6): Error and Status = %r\n",
> __FUNCTION__, Status));
> return Status;
> } else {
> Status = MmcHost->ReadBlockData (MmcHost, 0, 64, Buffer);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): ReadBlockData Error and Status =
> %r\n", Status));
> + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD6): ReadBlockData Error and Status
> = %r\n", __FUNCTION__, Status));
> return Status;
> }
> }
> @@ -459,20 +459,20 @@ InitializeSdMmcDevice (
> CmdArg = MmcHostInstance->CardInfo.RCA << 16;
> Status = MmcHost->SendCommand (MmcHost, MMC_CMD55, CmdArg);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD55): Error and Status = %r\n",
> Status));
> + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD55): Error and Status = %r\n",
> __FUNCTION__, Status));
> return Status;
> }
> /* Width: 4 */
> Status = MmcHost->SendCommand (MmcHost, MMC_CMD6, 2);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(MMC_CMD6): Error and Status = %r\n", Status));
> + DEBUG ((EFI_D_ERROR, "%a (MMC_CMD6): Error and Status = %r\n",
> __FUNCTION__, Status));
> return Status;
> }
> }
> if (MMC_HOST_HAS_SETIOS(MmcHost)) {
> Status = MmcHost->SetIos (MmcHost, 26 * 1000 * 1000, 4, EMMCBACKWARD);
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "%a(SetIos): Error and Status = %r\n", Status));
> + DEBUG ((EFI_D_ERROR, "%a (SetIos): Error and Status = %r\n",
> __FUNCTION__, Status));
> return Status;
> }
> }
> --
> 1.9.1
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
